Fix new columns names generation during split operation (#224) #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce a new scheme for the generation of columns names during split, which takes hierarchy into account * Add tests
Jolanrensen
approved these changes
Jan 25, 2023
| ): String { | ||
| // check if column with this name already exists in the df in the same position in the hierarchy, | ||
| // or we already have a column with this name in the list of columns to be inserted to the same position in the hierarchy | ||
| fun isUsed(name: String) = |
There was a problem hiding this comment.
Not very fond of inner functions, but you do reuse arguments from the outer function and it makes things more readable, so I think I'll let it slide :)
Jolanrensen
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new scheme for the generation of columns names during split, which takes hierarchy into account
Add tests