-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for swing tables integration in IDEA plugin #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there still a way for users to switch between Swing and HTML tables? Since Swing afaik doesn't support hierarchical tables yet. |
koperagen
reviewed
Mar 3, 2023
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/DataframeConvertable.kt
Outdated
Show resolved
Hide resolved
koperagen
reviewed
Mar 3, 2023
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/Integration.kt
Outdated
Show resolved
Hide resolved
Sure, but it is handled on IDEA side. Swing tables UI will be off by default until a hierarchical view support is added. |
ermolenkodev
force-pushed
the
unified-tables-dev
branch
2 times, most recently
from
March 6, 2023 15:55
bc2a1c4
to
21529f0
Compare
ileasile
reviewed
Mar 7, 2023
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/JupyterHtmlRenderer.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/JupyterHtmlRenderer.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/JupyterHtmlRenderer.kt
Show resolved
Hide resolved
ileasile
reviewed
Mar 7, 2023
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/Integration.kt
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/KotlinNotebookPluginUtils.kt
Outdated
Show resolved
Hide resolved
* Update kotlin-jupyter-api to 0.11.0-311 * Add functions for dynamic loading of dataframe rows in IDEA plugin * Temporary ignore vine notebook test
ermolenkodev
force-pushed
the
unified-tables-dev
branch
from
March 9, 2023 10:25
9d4499e
to
0371330
Compare
koperagen
reviewed
Mar 9, 2023
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/jupyter/Integration.kt
Outdated
Show resolved
Hide resolved
Insted respond with different output for kernel version >= 0.11.0.311
koperagen
approved these changes
Mar 10, 2023
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update kotlin-jupyter-api to 0.11.0-311
Add common interface for classes convertable to AnyFrame
Add functions for dynamic loading of dataframe rows in IDEA plugin
Temporary ignore vine notebook test