-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotations for parameters #1710
Conversation
...ns/base/src/main/kotlin/translators/descriptors/DefaultDescriptorToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/main/kotlin/translators/psi/DefaultPsiToDocumentableTranslator.kt
Outdated
Show resolved
Hide resolved
extra = annotations() | ||
) | ||
else -> GenericTypeConstructor( | ||
DRI.from(ctor!!), // TODO: remove '!!' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The !!
can be removed here IMHO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think so since it is nullable and afaik we dont have a nullable constructor for DRI
Minor comments, otherwise good to go. Not sure about the naming, although IMHO it's ok, any better ideas @Kordyjan? |
|
d144634
to
17adfaa
Compare
Name
Annotatable
is up to discussion, i am not entirely happy with it