Render react resources as separate css to allow overriding #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcinAman
force-pushed
the
overriding-react-styles
branch
from
e39d99c
to
fd31cc3
Compare
|
Given our current dsl is there any way to test it? |
|
/rebase |
github-actions
bot
force-pushed
the
overriding-react-styles
branch
from
fd31cc3
to
430c800
Compare
MarcinAman
force-pushed
the
overriding-react-styles
branch
3 times, most recently
from
7a9e04e
to
9808291
Compare
Kordyjan
suggested changes
Sep 8, 2020
MarcinAman
force-pushed
the
overriding-react-styles
branch
from
f71fec8
to
cf3927d
Compare
|
Rebased |
BarkingBad
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for that PR was the meeting with scala team, that faced an issue with not being able to override all styles. Also i thought it is weird that in order to override styles you need to modify 2 extension points so i've merged them into categories (styles, scripts and assets).