Fix merging documentations of modules and packages #1480
Conversation
| @@ -312,4 +312,66 @@ class LinkableContentTest : AbstractCoreTest() { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| fun `Include module with description parted in two files`() { | |||
There was a problem hiding this comment.
This IMHO is the wrong kind of test. You should really write a unit test for everything that is unit testable.
I am not proposing to remove this test, but adding a proper unit test as well!
There was a problem hiding this comment.
But with this engine we are doing mainly functional tests and this one does not look much different than the others
There was a problem hiding this comment.
Yes the project is almost entirely relying on functional tests and this is not ideal! This particular component was designed to support unit tests.
Maybe @Kordyjan can give further directions on this issue :)
| @@ -312,4 +312,66 @@ class LinkableContentTest : AbstractCoreTest() { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| fun `Include module with description parted in two files`() { | |||
There was a problem hiding this comment.
But with this engine we are doing mainly functional tests and this one does not look much different than the others
Yeah, is should be rebased on top of #1473 as it uses its new API, so it is necessary to wait until former gets merged |
MarcinAman
force-pushed
the
fix-merging-documnetation
branch
from
955378d
to
764cf57
Compare
kamildoleglo
force-pushed
the
fix-merging-documnetation
branch
from
33d4a2f
to
c792158
Compare
This PR will not build until #1473 will be merged into master