-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javadoc @inheritDoc tag support #1608
Conversation
efc7040
to
a5bd1e8
Compare
a5bd1e8
to
020acfc
Compare
plugins/base/src/main/kotlin/translators/psi/parsers/JavadocParser.kt
Outdated
Show resolved
Hide resolved
See( | ||
parseStringToDocNode(content.substringAfter(' ')), | ||
referencedName, | ||
externalDri(referencedName) | ||
dri?.fqName() ?: referencedName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't referencedName
be used by default and the fqname
as a fallback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have a fq name every time it is possible because:
/**
* @throws RuntimeException sample runtime exception
* @throws java.lang.IllegalStateException another one
*/
void foo()
If we have such a case then it is nice to unify those names to display them accordingly. I'd like to have a fq name since it is most often unique and can be used to distinguish tags, but i am open for discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugins/base/src/main/kotlin/translators/psi/parsers/InheritDocResolver.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/main/kotlin/translators/psi/parsers/JavadocParser.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/main/kotlin/translators/psi/parsers/JavadocParser.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/main/kotlin/translators/psi/parsers/JavadocParser.kt
Outdated
Show resolved
Hide resolved
plugins/base/src/test/kotlin/translators/JavadocInheritDocsTest.kt
Outdated
Show resolved
Hide resolved
4697079
to
e8825b3
Compare
No description provided.