-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate buildSrc to composite build #2912
Conversation
|
@aSemy could I ask you to take a quick look, please? Maybe you know a way to fix the gradle plugin without copying configuration |
I think converting the Dokka-GP to an included build would be a good step in the future (as well as the integration tests), but it might require a lot of work (e.g. the Worker API), and isn't necessary right now (unless I've missed something @Goooler?). I think this PR should just set up the bare minimum needed for using included build, and focus on improving the Dokka-GP in another PR. So I think just keep these changes:
And don't update to Gradle 8, and keep Dokka-GP as regular ol' subproject. WDYT? |
Ahh right, I see what you mean now. Yes, I think it's better to use the online version of Dokka. If there's problem in DokkaGP then it could prevent the whole project from compiling during development, which would be annoying. |
044053f
to
1171b14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, thanks! I've triggered integration tests, let's wait for them to pass
Everything looks good 🎉 |
Addressed from #2652.