Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy/remove unnecessary suppressions #2975

Merged

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Apr 23, 2023

  • Remove unused imports
  • Remove unnecessary @Suppress("FunctionName") - function names are allowed to be CamelCase if they are factory functions
    factory functions used to create instances of classes can have the same name as the abstract return type
    In cases where a suppress was required, I moved the annotation to be on the actual function, so as not to suppress warnings in other functions that might be invalid.

@aSemy aSemy force-pushed the tidy/remove_unnecessary_suppressions branch from 8d019ce to 31fc16a Compare April 23, 2023 09:27
@IgnatBeresnev IgnatBeresnev self-requested a review April 25, 2023 20:20
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

(I also prefer more isolated/narrowed down suppressions, been bitten a few times by file-wide ones already...)

@IgnatBeresnev IgnatBeresnev merged commit fcb2f4a into Kotlin:master Apr 25, 2023
@aSemy aSemy deleted the tidy/remove_unnecessary_suppressions branch April 25, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants