Improve Build Caching of Maven plugin tasks #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- separate classes/resources inputs - filter and annotate classes input: 1. only include `.class` files (the compileKotlin file includes caches) 2. annotate with `@Classpath` so Gradle will be able to normalize the files
adam-enko
added
the
infrastructure
…ich breaks Build Cachability), and add some comments
…` isn't Provider API compatible yet)
dkrasnoff
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tasks for building the Dokka Maven plugin, so that Build Cache works across machines.
(Alternative title: TIL that the compileKotlin task output includes caches)
Summary
Update MvnExec task:
.classfiles (the compileKotlin file includes caches)@Classpathso Gradle will be able to normalize the filesUpdate
generatePomtask to manually register the version inputs, to ensure Gradle will re-run the task if they change.Update
helpMojoResourcesto excludemaven-plugin-help.properties, because it contains a property with an absolute file path, meaning that Build Cache cannot be shared between CI and local machines.