Document how to use from Gradle #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vampire
reviewed
Sep 4, 2020
|
|
||
| Dukat will automatically run for npm dependencies by specifying the following in `build.gradle`: | ||
| ``` | ||
| kotlin.js.experimental.generateKotlinExternals=true |
There was a problem hiding this comment.
This is only correct for Kotlin/JS Gradle plugin 1.3.x.
With 1.4 the property was renamed and you can now even configure per dependency whether to run Dukat on it or not.
But do you really think this belongs in the Dukat documentation?
I think this is more suited in the Kotlin/JS Gradle Plugin documentation and actually it is documented there: https://kotlinlang.org/docs/reference/js-external-declarations-with-dukat.html
| ``` | ||
| import org.jetbrains.kotlin.gradle.targets.js.nodejs.NodeJsRootPlugin | ||
| ... | ||
| NodeJsRootPlugin.apply(project).apply { |
There was a problem hiding this comment.
Instead of applying the root plugin manually, you should just configure the extension like
configure<NodeJsRootExtension> {
versions.dukat.version = "0.5.7"
}Which should probably also be shown in the Kotlin/JS Gradle plugin documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.