Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sink::asNSOutputStream overwrites sink's buffer content #215

Closed
fzhinkin opened this issue Aug 24, 2023 · 0 comments · Fixed by #216
Closed

Sink::asNSOutputStream overwrites sink's buffer content #215

fzhinkin opened this issue Aug 24, 2023 · 0 comments · Fixed by #216
Assignees
@fzhinkin
Labels
bug

Comments

@fzhinkin
Copy link
Collaborator

Sink::asNSOutputStream incorrectly writes data by using the segment's pos offset instead of limit but then increments the limit.
@fzhinkin fzhinkin added the bug label Aug 24, 2023
@fzhinkin fzhinkin self-assigned this Aug 24, 2023
fzhinkin added a commit that referenced this issue Aug 24, 2023
@fzhinkin
Correctly write data into sink's internal buffer
3b2d134 
Fixes #215
@fzhinkin fzhinkin mentioned this issue Aug 24, 2023
Merged
@fzhinkin fzhinkin linked a pull request Aug 24, 2023 that will close this issue
Correctly write data into sink's internal buffer #216
Merged
jeffdgr8 added a commit to jeffdgr8/okio that referenced this issue Aug 24, 2023
@jeffdgr8
Fix from Kotlin/kotlinx-io#215
8b3fe7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzhinkin fzhinkin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly write data into sink's internal buffer Kotlin/kotlinx-io
1 participant
@fzhinkin