Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast EOF #111

Merged
merged 2 commits into from
May 12, 2020
Merged

Fast EOF #111

merged 2 commits into from
May 12, 2020

Conversation

qwwdfsad
Copy link
Collaborator

No description provided.

@qwwdfsad qwwdfsad marked this pull request as ready for review May 12, 2020 08:27
@qwwdfsad qwwdfsad requested a review from e5l May 12, 2020 08:27
@e5l
Copy link
Member

e5l commented May 12, 2020

Hi @qwwdfsad, thanks for the PR. As mentioned before, this change won't prevent filling the internal Input buffer. Could you add some measurements to compare the change?

@qwwdfsad
Copy link
Collaborator Author

Yeah, that's why I haven't touched our primitives like copyTo.
This change is more about readability and the code being straightforward, not about performance

@e5l
Copy link
Member

e5l commented May 12, 2020

LGTM

@qwwdfsad qwwdfsad merged commit c5bba01 into master May 12, 2020
@qwwdfsad qwwdfsad deleted the fast-eof branch May 12, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @e5l