-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented DSL with project isolation support #295
Conversation
- no refactoring - no kdocs - no docs - kotlin adapters failed - no tests on Android - no extended tests - no migration guide - no migration deprecations Resolves #284
- improve filters DSL - move functional tests - move Tool Variant to internal packages
- fix defaults example test - change report signature
- also fixed locators test
I think Dokka has the same problem with project isolation as this PR is fixing. Maybe Dokka engineers should check this setup when it is finished. |
- Android DSL
- improve DSL - fix Android tests
- try to fix Android test
src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/KoverProjectExtension.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/kotlinx/kover/gradle/plugin/tasks/AbstractKoverReportTask.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed everything, except:
src/main/kotlin/kotlinx/kover/gradle/plugin/tools/
(hope they didn't change much),
src/main/kotlin/kotlinx/kover/gradle/plugin/locators
and src/main/kotlin/kotlinx/kover/gradle/plugin/appliers
examples/android/minimal_kts/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/internal/KoverReportExtension.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/kotlinx/kover/gradle/plugin/dsl/internal/KoverReportExtension.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/kotlinx/kover/gradle/plugin/tasks/internal/KoverArtifactGenerationTask.kt
Show resolved
Hide resolved
src/main/kotlin/kotlinx/kover/gradle/plugin/locators/KotlinMultiPlatformLocator.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Leonid Startsev <sandwwraith@users.noreply.github.com>
Co-authored-by: Leonid Startsev <sandwwraith@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific job! 🔥
I believe it's good to go as alpha already, so we can get more feedback regarding API shape before further bikeshedding and stabilization
Implemented new version of Kover Gradle plugin DSL
Resolves Implement new Kover DSL with project isolation support #284
Added Gradle project isolation support
Resolves Project Isolation support #144
Fixes Failed to apply plugin 'org.jetbrains.kotlinx.kover', Cannot run Project.afterEvaluate(Action) when the project is already evaluated #221
Introduced API for Coverage Tools
The add-on system for Coverage Tools is not implemented at the moment, however, a dedicated API will simplify writing your tool in the plugin fork
Resolves JaCoCo Agent Override #195
Added support of Android build variants
Resolves Advanced Android support #18
Implemented support filtering of source sets for Kotlin JVM and Kotlin compilations for Kotlin MPP
Resolves commonTest should be skipped #245
Fixed missing report path in logs for cached HTML task
Fixes The path to the HTML report is not printed when extracting the result from the build cache #283
Added customizable header in HTML report for Kover and JaCoCo report generator
Fixes JaCoCo Report Title #194