Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented DSL with project isolation support #295

Merged
merged 34 commits into from
Feb 27, 2023
Merged

Implemented DSL with project isolation support #295

merged 34 commits into from
Feb 27, 2023

Conversation

shanshin
Copy link
Collaborator

@shanshin shanshin commented Jan 19, 2023

- no refactoring
- no kdocs
- no docs
- kotlin adapters failed
- no tests on Android
- no extended tests
- no migration guide
- no migration deprecations

Resolves #284
- improve filters DSL
- move functional tests
- move Tool Variant to internal packages
- fix defaults example test
- change report signature
- fix Android tests
- also fixed locators test
- fixed legacy appliers
- fixed additing source sets
- change project name to avoid future collision with maven artifacts in
@JavierSegoviaCordoba
Copy link

I think Dokka has the same problem with project isolation as this PR is fixing. Maybe Dokka engineers should check this setup when it is finished.

build.gradle.kts Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
docs/migration-to-0.7.0.md Outdated Show resolved Hide resolved
examples/jvm/defaults/build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed everything, except:

src/main/kotlin/kotlinx/kover/gradle/plugin/tools/ (hope they didn't change much),
src/main/kotlin/kotlinx/kover/gradle/plugin/locators and src/main/kotlin/kotlinx/kover/gradle/plugin/appliers

build.gradle.kts Outdated Show resolved Hide resolved
docs/migration-to-0.7.0.md Outdated Show resolved Hide resolved
docs/migration-to-0.7.0.md Outdated Show resolved Hide resolved
examples/jvm/defaults/build.gradle.kts Show resolved Hide resolved
@Kotlin Kotlin deleted a comment from sandwwraith Feb 21, 2023
shanshin and others added 9 commits February 22, 2023 14:06
- review fixes
- Gradle 8 fixes
- started migration steps
- fix Android tests
- renamed use...ToolDefault()
- renamed taskNames(), className(), packageName()
- renamed multi-platform
- renamed kmp to mpp
- added deprecations for old DSL classes
Co-authored-by: Leonid Startsev <sandwwraith@users.noreply.github.com>
Co-authored-by: Leonid Startsev <sandwwraith@users.noreply.github.com>
@shanshin shanshin changed the title DSL prototype Implemented DSL with project isolation support Feb 23, 2023
Copy link
Contributor

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terrific job! 🔥

I believe it's good to go as alpha already, so we can get more feedback regarding API shape before further bikeshedding and stabilization

@shanshin shanshin merged commit 264e34b into main Feb 27, 2023
@shanshin shanshin deleted the dsl branch February 27, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment