Error in withTimeout(Duration.ZERO)

[fvasco]

I found a regression bug #870 in manual merge #1006

import kotlinx.coroutines.time.withTimeout
import kotlinx.coroutines.withTimeout
import java.time.Duration

suspend fun main() {
    withTimeout(Duration.ZERO) {} // Duration works
    withTimeout(0) {} // Long does not work
}

Proposed changes are:

fun Duration.coerceToMillis(): Long {
    if (this <= Duration.ZERO) return 0
    if (this <= ChronoUnit.MILLIS.duration) return 1

    // Maximum scalar values of Duration.ofMillis(Long.MAX_VALUE)
    val maxSeconds = 9223372036854775
    val maxNanos = 807000000
    return if (seconds < maxSeconds || seconds == maxSeconds && nano < maxNanos) toMillis()
    else Long.MAX_VALUE
}

or original PR (logharitmic search):

fun Duration.toMillisDelay(): Long =
        if (this <= ChronoUnit.MILLIS.duration) {
            if (this <= Duration.ZERO) 0
            else 1
        } else {
            // Maximum scalar values of Duration.ofMillis(Long.MAX_VALUE)
            val maxSeconds = 9223372036854775
            val maxNanos = 807000000
            if (seconds < maxSeconds || seconds == maxSeconds && nano < maxNanos) toMillis()
            else Long.MAX_VALUE
        }

[fvasco]

Moreover this bug introduces an unrequested delay in case of delay(Duration.ZERO), it become delay(1L).
In this case it avoids delay(Long) fast path.