Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Monte-Carlo Approach for the Producer-Consumer Channel Benchmark #1427

Closed
wants to merge 1 commit into from
Closed

Using Monte-Carlo Approach for the Producer-Consumer Channel Benchmark #1427

wants to merge 1 commit into from

Conversation

fmixing
Copy link
Contributor

@fmixing fmixing commented Aug 8, 2019 •
edited

The development mode works under 10 minutes now on macbook pro 13" (2017): BUILD SUCCESSFUL in 8m 38s.
You can see the results on AWS m5.24xlarge in the attached pdf file.
channel-prod-cons-monte-carlo.pdf

@fmixing fmixing requested a review from ndkoval August 8, 2019 15:44
ndkoval
ndkoval requested changes Aug 8, 2019
View reviewed changes
benchmarks/build.gradle Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/montecarlo/BenchmarkConfiguration.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/montecarlo/BenchmarkConfiguration.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/montecarlo/BenchmarkConfiguration.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/montecarlo/BenchmarkConfiguration.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/montecarlo/BenchmarkConfiguration.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/montecarlo/MonteCarloBasedChannelBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/montecarlo/MonteCarloBasedChannelBenchmark.kt Outdated Show resolved Hide resolved
@fmixing fmixing changed the base branch from master to develop September 4, 2019 13:27
ndkoval
ndkoval requested changes Sep 16, 2019
View reviewed changes
benchmarks/src/main/kotlin/BenchmarkUtils.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/ChannelProducerConsumerBenchmarkWorker.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/channel/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/channel/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/channel/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/channel/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/channel/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/channel/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/jmh/kotlin/benchmarks/ChannelProducerConsumerBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/ChannelProducerConsumerBenchmarkWorker.kt Outdated Show resolved Hide resolved
ndkoval
ndkoval requested changes Sep 24, 2019
View reviewed changes
benchmarks/src/main/kotlin/ChannelProducerConsumerBenchmarkIteration.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/ChannelProducerConsumerBenchmarkIteration.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/ChannelProducerConsumerBenchmarkIteration.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/ChannelProducerConsumerBenchmarkIteration.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/ChannelProducerConsumerBenchmarkIteration.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/BenchmarkUtils.kt Outdated Show resolved Hide resolved
benchmarks/src/jmh/kotlin/benchmarks/ChannelProducerConsumerBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/jmh/kotlin/benchmarks/ChannelProducerConsumerBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/benchmarks/channel/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/benchmarks/channel/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
@fmixing fmixing requested a review from ndkoval November 10, 2019 22:14
@ndkoval ndkoval changed the title Montecarlobench Using Monte-Carlo Approach for the Producer-Consumet Channel Benchmark Nov 15, 2019
@qwwdfsad qwwdfsad self-requested a review November 21, 2019 12:57
qwwdfsad
qwwdfsad requested changes Nov 21, 2019
View reviewed changes
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd continue reviewing this PR as soon as I am able to do a short complete run (=> "development configuration" is implemented)

benchmarks/build.gradle Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/macrobenchmarks/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/macrobenchmarks/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
benchmarks/src/main/kotlin/macrobenchmarks/ChannelProducerConsumerMonteCarloBenchmark.kt Outdated Show resolved Hide resolved
ndkoval
ndkoval requested changes Feb 11, 2020
View reviewed changes
Copy link
Member

@ndkoval ndkoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python script for generating plots does not work if only one dispatcher is used.

@qwwdfsad qwwdfsad force-pushed the develop branch 3 times, most recently from 4a49830 to aff8202 Compare March 10, 2020 17:27
@ndkoval ndkoval force-pushed the montecarlobench branch 5 times, most recently from ce84972 to 3acf2c5 Compare June 2, 2020 20:09
@ndkoval ndkoval changed the title Using Monte-Carlo Approach for the Producer-Consumet Channel Benchmark Using Monte-Carlo Approach for the Producer-Consumer Channel Benchmark Jun 2, 2020
@ndkoval
Add a microbenchmark for channels that uses the Monte-Carlo approach …
b823a1b 
…to test on a wide range of contended scenarios
qwwdfsad
qwwdfsad requested changes Jul 3, 2020
View reviewed changes
benchmarks/src/main/kotlin/benchmarks/common/ChannelProdConsBenchmarkIteration.kt
if (withSelect) {
select<Unit> {
channel.onSend(element) {}
dummy!!.onReceive {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please documents what's the purpose of dummy

benchmarks/src/main/kotlin/benchmarks/common/ChannelProdConsBenchmarkIteration.kt
/**
* Runs a batch send-receive pairs under the specified workload.
*/
public abstract class ChannelProdConsBenchmarkIteration(
Copy link
Member

@qwwdfsad qwwdfsad Jul 3, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the only possible way to understand the structure of the benchmark (what does it measure, how to interpret its results, how does it split the workload, what's the relationship between producers and consumers, what caveats does it have etc.) can be understood only from studying the source code, which doesn't seem really maintainable.

Please describe the top-level process in the root KDoc

@qwwdfsad qwwdfsad closed this Jun 7, 2021
@qwwdfsad qwwdfsad deleted the montecarlobench branch July 12, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad requested changes

@ndkoval ndkoval ndkoval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmixing @qwwdfsad @ndkoval