Stacktrace recovery improvements and documentation #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce CopyableThrowable to provide a mechanism for flexible exception cloning * Do not reflectively clone exceptions with additional non-static fields
…very. Not included in a guide intentionally
elizarov
suggested changes
Feb 5, 2019
pakoito
reviewed
Feb 7, 2019
The code is also refactored a bit to avoid repetition and long lines Fixes #987
|
I've also added a fix for #987 to this branch. The problem was not with the default, though, but with the fact that constructor with string message was not used when trying to copy exception, but should have been. |
elizarov
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #917, #921, #859 and #948