-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minimum length password wording (character number) #792
Conversation
Thanks for taking your time to fix these errors. Unfortunately, translations are handled in Crowdin and moving committed changes back into the translation system is more work than changing it there. If you have an account there and you're willing to redo it there, let me know. Otherwise I will make them myself. |
I missed that, I can update Crowdin through the weekend. 👍 |
@Kovah I've submitted the Crowdin suggestions, and I think the en_US still needs to be fixed in code (and the tests). |
Awesome, many thanks! |
Hm, something doesn't seem right. Will have a look later. |
I noticed that the test was failing because of minimal character number in artisan cli, I have committed the fix - now it will match the other parts and 8 characters. |
I noticed the actual wording is different than the actual behavior.
Wording says 10 characters limit:
But the behavior is 8 characters.