Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readibility of _select_source function #500

Merged
merged 1 commit into from Sep 6, 2017
Merged

Improve readibility of _select_source function #500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 12 additions & 15 deletions weasyprint/__init__.py
View file
Open in desktop
Expand Up @@ -299,9 +299,14 @@ def _select_source(guess=None, filename=None, url=None, file_obj=None,
if base_url is not None:
base_url = ensure_url(base_url)

nones = [
param is None for param in (guess, filename, url, file_obj, string)]
if nones == [False, True, True, True, True]:
selected_params = [
param for param in (guess, filename, url, file_obj, string) if
param is not None]
if len(selected_params) != 1:
raise TypeError('Expected exactly one source, got ' + (
', '.join(selected_params) or 'nothing'
))
elif guess:
if hasattr(guess, 'read'):
type_ = 'file_obj'
elif url_is_absolute(guess):
Expand All @@ -316,12 +321,12 @@ def _select_source(guess=None, filename=None, url=None, file_obj=None,
**{str(type_): guess})
with result as result:
yield result
elif nones == [True, False, True, True, True]:
elif filename:
if base_url is None:
base_url = path2url(filename)
with open(filename, 'rb') as file_obj:
yield 'file_obj', file_obj, base_url, None
elif nones == [True, True, False, True, True]:
elif url:
with fetch(url_fetcher, url) as result:
if check_css_mime_type and result['mime_type'] != 'text/css':
LOGGER.error(
Expand All @@ -338,24 +343,16 @@ def _select_source(guess=None, filename=None, url=None, file_obj=None,
yield (
'file_obj', result['file_obj'], base_url,
proto_encoding)
elif nones == [True, True, True, False, True]:
elif file_obj:
if base_url is None:
# filesystem file-like objects have a 'name' attribute.
name = getattr(file_obj, 'name', None)
# Some streams have a .name like '<stdin>', not a filename.
if name and not name.startswith('<'):
base_url = ensure_url(name)
yield 'file_obj', file_obj, base_url, None
elif nones == [True, True, True, True, False]:
elif string:
yield 'string', string, base_url, None
else:
raise TypeError('Expected exactly one source, got ' + (
', '.join(
name for i, name in enumerate(
('guess', 'filename', 'url', 'file_obj', 'string'))
if not nones[i]
) or 'nothing'
))

# Work around circular imports.
from .css import preprocess_stylesheet # noqa
Expand Down