Address PR comments microsoft#3

Kr1sso · Oct 29, 2019 · 9b26861 · 9b26861
1 parent 0706e99
commit 9b26861
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Public/Src/Engine/Scheduler/PipExecutor.cs b/Public/Src/Engine/Scheduler/PipExecutor.cs
@@ -1382,7 +1382,7 @@ public static async Task<ExecutionResult> ExecuteProcessAsync(
                                 registerQueryRamUsageMb(
                                     () =>
                                     {
-                                        using (operationContext.StartAsyncOperation(PipExecutorCounter.QueryRamUsageDuration))
+                                        using (counters[PipExecutorCounter.QueryRamUsageDuration].Start())
                                         {
                                             lastObservedPeakRamUsage =
                                                 (int)ByteSizeFormatter.ToMegabytes((long)(executor.GetActivePeakWorkingSet() ?? 0));

diff --git a/Public/Src/Engine/Scheduler/Tracing/Log.cs b/Public/Src/Engine/Scheduler/Tracing/Log.cs
@@ -1219,7 +1219,7 @@ internal abstract void CacheTransferStats(
             EventLevel = Level.Verbose,
             Keywords = (int)Keywords.UserMessage,
             EventTask = (ushort)Tasks.Scheduler,
-            Message = "Failed to get the current memory pressure level - resource cancelation will be skipped all together! Available RAM MB: {availableRam} < {minimumAvailableRam})" +
+            Message = "Failed to get the current memory pressure level - resource cancelation will only take /minimumAvailableRam and /maximumRamUtilization into account! Available RAM MB: {availableRam} < {minimumAvailableRam})" +
             " && (used RAM percentage: {ramUtilization} > {maximumRamUtilization}) ")]
         internal abstract void UnableToGetMemoryPressureLevel(
             LoggingContext loggingContext,