Merging with mainline OpenJazz?

[vanfanel]

Hi, @KranKRival !

I also tried to port OpenJazz to SDL2 but ultimately failed. You seem to have succeeded and it OpenJazz really needs SDL2 support. Have you though about merging with upstream OpenJazz in https://github.com/AlisterT/openjazz ?

Maybe you are up to fixing the remaining bugs before merging?

Thanks!

[KranKRival]

well 1st of all yes i need to fix all the bugs that left , later compile backport it to linux and see how all perform and than i could send the pr , as this project now compiles for the nintendo switch only

[KranKRival]

thank you ill keep the issue open until farder changes

[KranKRival]

[KranKRival]

i have back ported it to linux with sdl2 fully working :)

[vanfanel]

@KranKRival This is what OpenJazz needed AT LAST!! :)
Will you please merge it upstream to https://github.com/AlisterT/openjazz ?

[KranKRival]

i will send pr after ill finish final tests

[rtissera]

sorry to relive that dead thread, but is anyone still planning to do that ?
It would be great to have it mainlined since OpenJazz original repo is still active.

[vanfanel]

I have also remembered this today. SDL2 support in OpenJazz is much needed, yes.

[KranKRival]

Depends on maybe n repo I did my job and ported it over

…

On Mon, Nov 8, 2021, 23:06 Manuel Alfayate Corchete < ***@***.***> wrote: I have also remembered this today. SDL2 support in OpenJazz is much needed, yes. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNC3EN4CBKON6OXU2WDTLLULA3U7ANCNFSM4JBZPRZA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[vanfanel]

Depends on maybe n repo I did my job and ported it over
…
On Mon, Nov 8, 2021, 23:06 Manuel Alfayate Corchete < @.***> wrote: I have also remembered this today. SDL2 support in OpenJazz is much needed, yes. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNC3EN4CBKON6OXU2WDTLLULA3U7ANCNFSM4JBZPRZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Did you do a Pull Request so it gets merged?

[KranKRival]

No, I didn't. Its not cleaned and to do so some one need to clean the job I'm not going too I remember main stream wanted to do so I sadly have no time to afford to do so On Tue, Nov 9, 2021, 14:19 Manuel Alfayate Corchete < ***@***.***> wrote:

…

Depends on maybe n repo I did my job and ported it over … <#m_4265999660068929411_> On Mon, Nov 8, 2021, 23:06 Manuel Alfayate Corchete < *@*.***> wrote: I have also remembered this today. SDL2 support in OpenJazz is much needed, yes. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment) <#1 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADNC3EN4CBKON6OXU2WDTLLULA3U7ANCNFSM4JBZPRZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . Did you do a Pull Request so it gets merged? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADNC3EJRMMK6ECBAJEBJYVDULEGTVANCNFSM4JBZPRZA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.