Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] Implicit usings removed if enabled #58 #64

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

KreativJos
Copy link
Owner

@KreativJos KreativJos commented Feb 9, 2022

Issues:

src/project/csprojReader.ts Outdated Show resolved Hide resolved
src/template/template.ts Outdated Show resolved Hide resolved
KreativJos added a commit that referenced this pull request Mar 27, 2022
Removed useless newline in template.ts\nOptimized try/catch in csprojreader
@bard83
Copy link
Collaborator

bard83 commented Mar 28, 2022

Should possibly check for other global usings?

if it makes the extension smarter, the answer would be yes. OTOH if it increases the code complexity I'd wait a moment.

Removed useless newline in template.ts\nOptimized try/catch in csprojreader
@bard83 bard83 force-pushed the feature/58-implicitUsings branch from 74ca341 to 076cbfd Compare July 5, 2023 20:52
@bard83 bard83 force-pushed the feature/58-implicitUsings branch from 076cbfd to f99f071 Compare July 5, 2023 21:15
@bard83
Copy link
Collaborator

bard83 commented Jul 27, 2023

Should possibly check for other global usings?

if it makes the extension smarter, the answer would be yes. OTOH if it increases the code complexity I'd wait a moment.

Questions:

  • where should this global using file be located?
  • should be configurable on workspace level?

I'd prefer to keep it out at the moment and open a new RF for it, at least until the thing gets clearer.

@bard83 bard83 marked this pull request as ready for review July 27, 2023 15:44
@bard83 bard83 merged commit 582a269 into master Jul 27, 2023
3 checks passed
@bard83 bard83 deleted the feature/58-implicitUsings branch July 27, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants