#51 - Added Unsubscribe in UseEffect

KrisTheCanadian · Mar 28, 2022 · 230561b · 230561b
1 parent 4fd95ae
commit 230561b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/components/dashboard/AdminDashboard/AdminDashboard.tsx b/src/components/dashboard/AdminDashboard/AdminDashboard.tsx
@@ -74,7 +74,7 @@ function AdminDashboard() {
   };
 
   useEffect(() => {
-    usersRef.onSnapshot(async (snapshot) => {
+    const unsubscribe = usersRef.onSnapshot(async (snapshot) => {
       let tableData = new Array<UnassignedPatientTableData>();
       snapshot.forEach((childSnapshot) => {
         const user = childSnapshot.data();
@@ -86,6 +86,10 @@ function AdminDashboard() {
       setNbUnassignedPatients(tableData.length);
     });
 
+    return () => {
+      unsubscribe();
+    };
+
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 

diff --git a/src/components/layout/NotificationsMenuItem.tsx b/src/components/layout/NotificationsMenuItem.tsx
@@ -32,12 +32,15 @@ function NotificationsMenuItem() {
   };
 
   useEffect(() => {
-    onSnapshot(doc(firestore, 'users', `${state.id}`), (docu) => {
+    const unsubscribe = onSnapshot(doc(firestore, 'users', `${state.id}`), (docu) => {
       const data = docu.data();
       if (data && data.notifications) {
         setNotifications(data.notifications);
       }
     });
+    return () => {
+      unsubscribe();
+    };
     // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);