Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rlib example actions #1

Closed
wants to merge 17 commits into from
Closed

Conversation

KrishanBhasin
Copy link
Owner

@KrishanBhasin KrishanBhasin commented Apr 28, 2020

Description

Move from TravisCI to GitHub Actions for our CI pipeline.

Motivation and Context

Travis CI have undergone some changes and with the utility of GitHub Actions no longer seems like the right fit for the CI for this package.
This PR moves us over to GitHub actions, using the templates from https://github.com/r-lib/actions

How Has This Been Tested?

I have been running the CI against my personal fork at https://github.com/KrishanBhasin/dataCompareR/

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@KrishanBhasin KrishanBhasin changed the base branch from dev to master April 12, 2021 13:15
@KrishanBhasin
Copy link
Owner Author

pkgdown failing due to r-lib/pkgdown#1378

will add the keywords

@KrishanBhasin
Copy link
Owner Author

Still getting warnings:

Warning messages:
1: Topics missing from index: 
* allVarMatchMessage
* checkEmpty
* checkForRCompareCol
* checkKeysExist
* checkNA
* checkUniqueness
* cleanColNames
* coerceData
* coerceFactorsToChar
* collapseClasses
* colsWithUnequalValues
* compareData
* compareNames
* createAntiSubset
* createCleaningInfo
* createColMatching
* createCompareObject
* createMeta
* createMismatchObject
* createMismatches
* createReportText
* createRowMatching
* createTextSummary
* currentObjVersion
* executeCoercions
* getCoercions
* getMismatchColNames
* is.dataCompareRobject
* isNotNull
* isSingleNA
* listObsNotVerbose
* listObsVerbose
* locateMismatches
* makeValidKeys
* makeValidNames
* matchColumns
* matchMultiIndex
* matchNoIndex
* matchRows
* matchSingleIndex
* metaDataInfo
* mismatchHighStop
* orderColumns
* outputSectionHeader
* prepareData
* processFlow
* rcompObjItemLength
* rounddf
* subsetDataColumns
* trimCharVars
* updateCompareObject
* updateCompareObject.cleaninginfo
* updateCompareObject.colmatching
* up [... truncated] 
2: Failed to parse example for topic 'makeValidKeys' 

@KrishanBhasin
Copy link
Owner Author

It would be nice to have the pkgdown site built (but not published) on PRs, and built & published on commits to master

@KrishanBhasin
Copy link
Owner Author

We could do this using conditionals

An example from those docs:

name: CI
on: push
jobs:
  prod-check:
    if: ${{ github.ref == 'refs/heads/main' }}
    runs-on: ubuntu-latest
    steps:
      - run: echo "Deploying to production server on branch $GITHUB_REF"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant