Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: provide an option to turn the warnings of check_missing_topics() into errors. #1378

Closed
ThierryO opened this issue Aug 13, 2020 · 3 comments · Fixed by #1395
Closed
Labels
deploy ✈️ feature a feature request or enhancement

Comments

@ThierryO
Copy link
Contributor

I would find this useful when running in CI to make sure that the pkgdown website covers all helpfiles.

Possible implementations:

  • via argument in _pkgdown.yml
  • via environment variable cfr NOT_CRAN.
  • via extra argument

I'd suggest three possible states:

  • never (default, alias: FALSE)
  • non-interactive
  • always (alias: TRUE)

I'm happy to send a PR.

@hadley hadley added deploy ✈️ feature a feature request or enhancement labels Aug 20, 2020
@hadley
Copy link
Member

hadley commented Aug 20, 2020

Hmmm, maybe it could default to true if CI is true. Then you wouldn't need a separate env var, just an option.

A PR would be great 😄

@ldecicco-USGS
Copy link

FYI, when CI is TRUE is exactly the time I don't want this to error 🙃. I'm trying to make my online documentation (created from a github action) to be as clean and user-friendly as possible. So, purposely leaving off some of the lesser-used functions (but I'd still like to have those help files available to more power-users who are more familiar with native R help files)

So, is there anyway in a within:

pkgdown::deploy_to_branch(new_process = FALSE)

to specify ignore the check_missing_topics?

@hadley
Copy link
Member

hadley commented Oct 9, 2020

@ldecicco-USGS those topics can have @keywords internal so they don’t appear in the index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy ✈️ feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants