Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version 1.2.0 re-introduces issue #18 #34

Closed
fnsign opened this issue Jan 31, 2022 · 3 comments
Closed

Latest version 1.2.0 re-introduces issue #18 #34

fnsign opened this issue Jan 31, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@fnsign
Copy link

fnsign commented Jan 31, 2022

The last update to v1.2.0 re-introduces the problem with the MMM-Netatmo module, reported in detail in issue #18.
I could reproduce it by changing the declaration from let back to var

@fnsign fnsign added the bug Something isn't working label Jan 31, 2022
@KristjanESPERANTO
Copy link
Owner

Sorry that this happened again. In the fork you mentioned in #18, the variable UserPresence is used, that's the problem. I have changed it back to var, but actually there should be another solution here. But for that you would have to change all the modules that work with this variable.

Just for interest: why are you using a fork of MMM-Netatmo and not the upstream project, which is obviously still active: https://github.com/CFenner/MMM-Netatmo

@fnsign
Copy link
Author

fnsign commented Feb 1, 2022

Thanks a lot for fixing the issue so quickly!
The reason, why I use that specific fork is that I'm running two netatmo stations in two different houses and that module allows for selecting which station should be displayed on MM (deviceNumber). I searched quite intensively, but this fork was the only one that met my requirements. You can have multiple stations under one Netatmo account, but the @CFenner module (and most of other forks) pick the first installed station only.

@CFenner
Copy link

CFenner commented Feb 1, 2022

Actually, I paused the development for quite some time. Just recently I added the ability to load all stations of an account. Stations from different accounts are not supported, but one may invite guest user to a station. Maybe that helps.

KristjanESPERANTO added a commit that referenced this issue Feb 7, 2022
* let -> const

* let -> const

* Add PTHAFASDomBuilder as global variable

* Remove 'self' because it's never used

* eslint

* eslint + prettier

* Add prettier

* fix test

* Switch to eslint-config-airbnb-base for eslint

* Remove "use strict"
"use strict" is unnecessary inside of modules

* Add space after //

* Simplify methods

* Change string concatenation

* Remove unnecessary variable assignments

* Use typeof

* Prettier

* Add moment as dependency

* Use camel case

* Remove unnecessary 'else' after 'return'

* Change = to +=

* "default-case": "off"

* Use static for methods without this

* Revert "Use static for methods without this"

This reverts commit 95064a9.

* Add eslint rules

* Use this

* Add JSDoc comments

* Raise version to 1.2.0

* Update README.md

* Add a GitHub Actions CI workflow

* Remove Preconditions

* let UserPresence -> var UserPresence
To fix #34

* Bump eslint from 8.7.0 to 8.8.0 (#33)

Bumps [eslint](https://github.com/eslint/eslint) from 8.7.0 to 8.8.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.7.0...v8.8.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove dependency from "array-unique".

* 'arrayUnique' was used before it was defined

* Remove dependency from "arr-diff"

* Raise version

* Add configuration option `ignoreRelatedStations`

* Optimize configuration part

* Raise version to 1.3.0

* Fix typo

* Show "plattform" as default
Those who do not need it can deactivate it via `tableHeaderOrder`.

* Optimize configuration part

* Add css for Magdeburg

* Add note for city css files

* Fix line 8

* Use 'stylelint' for css files

* Update lint command

* Use kebab-case for class names

* Optimize

* Add blank

* Raise version to 1.4.0

* npm install --omit=dev

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants