Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest update breakes MariusEng / MMM-Netatmo #18

Closed
fnsign opened this issue Jul 5, 2021 · 3 comments
Closed

Latest update breakes MariusEng / MMM-Netatmo #18

fnsign opened this issue Jul 5, 2021 · 3 comments

Comments

@fnsign
Copy link

fnsign commented Jul 5, 2021

Describe the bug
After updating your module to the latest version, the MMM-Netatmo (fork fromMariusEng https://github.com/MariusEng/MMM-Netatmo) completely dissapears from the display. There is no error code or similar, it is completly not visible any more.

To Reproduce
Steps to reproduce the behavior:

  1. go to Magic ~/MagicMirror/modules/MMM-PublicTransportHafas
  2. git pull
  3. npm install
  4. reboot

Expected behavior
The MMM-Netatmo module should still remain visible

Screenshots

Additional context

@fnsign
Copy link
Author

fnsign commented Jul 15, 2021

I think I found where the problem is (I hope so from my very basic understanding)
In MMM-PublicTransportHafas.js you recently changed the variable declarations from var to let.
Im not sure, but the declaration of userPresensence should be globally availabe, and not locally within the function. (this is at least what I understood what var vs. let means).
When I change
let UserPresence = true; //true by default, so no impact for user without a PIR sensor

back to
var UserPresence = true; //true by default, so no impact for user without a PIR sensor
the MMM-Netatmo module appears again. Could you fix that?

@KristjanESPERANTO
Copy link
Owner

KristjanESPERANTO commented Aug 24, 2021

Sorry, I didn't get a notification about your issue. I'll try to see into it soon 🙂

KristjanESPERANTO added a commit that referenced this issue Sep 5, 2021
Change variable declaration back to var because of #18
@KristjanESPERANTO
Copy link
Owner

I still don't understand why this is causing problems with MMM-Netatmo. This module doesn't use the variable UserPresence. Even so, I made the change you suggested 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants