New SDK implemention, elixir-builder and so on

[zyuyou]

1.< new Project > is very simple, just create source-dir lib, but I will implement new one which like "mix new options"

2. < Create project from existing sources > just detect the project' sdkType, maybe should detect the sourceRoot too, but mix importWizard is more powerfull.



3. runconfiguration which use mix tool, and I will add mix ex-unit runconfiguration too in the future because it was a difficult job.
4. elixir-builder, now we can use shift+command+F9 or command+B to compile source file or make project and module.


5.add some new fileTemplates and also separate new-Elixir-File from others as a new group.

[KronicDeth]

• Did you mean to name this method doBuildWithElixirc instead of doBuildWithElixic? It looks like you're missing the r at the end of Elixir.

[zyuyou]

yes, r missed. it should be doBuildWithElixirc

[zyuyou]

All most of these issues mentioned in the comments above had been fixed, except the smallidea one.
and my master branch had pass the travis-ci test, but this PR has some conflicts now, considering you are fixing the parser feature, I will merge your master branch again when your work is done, ok?

[KronicDeth]

@zyuyou I just released v1.0.0, so you can now merge master into your PR branch.

[KronicDeth]

Do you have verification steps or a test plan you were using to manually test each feature? This will serve as the basis of my manual testing and the feature explanations that go in the README.

[zyuyou]

Just two tests, MixProjectImportBuilderTest for MixImportWizard and ElixirBuilderTest for ElixirBuilder.

[zyuyou]

@KronicDeth , Would you like to make ElixirFile like ErlangFile and ErlangFileImpl? so that I can get defmodule[] by using ElixirFile.getModules() like ErlangFile.getAttributes() .

if you not, in order to resolve this todo, I just got defmodule by the method showed in the screenshots, but I think that is not good, do you have any good suggestion?

[KronicDeth]

You can resolve that TODO after I land this PR (which I'll hopefully do tonight, in 10 -12 hours). I don't want to delay landing this more than I've already done while you had to wait for me to finish v1.0.0.

[KronicDeth]

@zyuyou I merged the PR to master, but when I was updating the README with all the features you added I wasn't able to get Build > Compile or Build > Make Project to error out when there was an error in the file to be built, but mix compile does show the error.

Here's my test file:

defmodule IntellijElixir.Quoter do
  broken
  use GenServer

  def start_link(args, opts \\ []) do
    GenServer.start_link(__MODULE__, args, opts)
  end

  def handle_call(code, _from, state) do
    {:reply, Code.string_to_quoted(code), state}
  end
end

The function call broken is undefined and it is properly flagged as an error with mix compile:

== Compilation error on file lib/intellij_elixir/quoter.ex ==
** (CompileError) lib/intellij_elixir/quoter.ex:2: undefined function broken/0
    (stdlib) lists.erl:1352: :lists.mapfoldl/3
    (stdlib) erl_eval.erl:657: :erl_eval.do_apply/6

If I do Build > Compile I get "Compilation completed successfully" in the Event Log with no error message.

How did you test the Build > Compile shows errors correctly?

[KronicDeth]

My last comment may be a due to a packaging or install error. I get the proper Messages Compiles tab with errors when I run the plugin in the debugger using Plugin > Elixir run configuration.

The last time something like this happened, it was due to directories not being copied in the .zip and jars correctly. I'll figure out it, no need for you to debug it.

[KronicDeth]

Confirmed it's a packaging problem. intellij-erlang's .zip contains the jps jars that are in compilerServer classpath:

but intellij-elixir does not

So, I just need to figure out how to get the jsp jars into the zip.

[KronicDeth]

I found a work-around: instead of using the zip made by "Build > Prepare Plugin for deployment", I do "Build > Build Artifact > intellij-elixir.zip", which includes the jps jars. I'm waiting on a response to a question in the Open API forum to see if I can go back to using "Prepare Plugin for deployment".

[zyuyou]

"Build > Build Artifact > intellij-elixir.zip"

Yes, I did the same. But I wonder why those .jar like junit-4.11.jar should be packaged in the final .zip ？

[KronicDeth]

The official answer from Jetbrains is that using Build Artifact is the correct way to do the build since "Prepare Plugin for deployment" always uses a fixed layout.

junit-4.11.jar is in the build because some of the classes in the org.elixir_lang namespace, such as org.elixir_lang.intellij_elixir.Quoter have assert* methods that wrap assert* methods from junit. Those methods are currently only used in testing and I just haven't had time to separate the testing parts of the code from the production part of the code, so junit is a dependency of intellij-elixir.zip.

[zyuyou]

❤️ thanks.

[jejacks0n]

This is great, and thanks for the work. I'm following (I think) everything that I should be doing, but keep getting the same result with my setup.

/usr/local/Cellar/elixir/1.2.4/bin/elixir "" -S phoenix.server
No file named 

It appears to be putting "" in the command in a way I can't circumvent. Is this to be expected, and am I using it wrong? Let me know if I should open an issue, or am doing something incorrectly.

[KronicDeth]

@jejacks0n: The "" would be the location of mix. You may have opened the project incorrectly. You need to import the project as a mix project for the location of mix to be set using The README instructions for importing a project from an external model

In the future, please open a new issue if you need help. Asking for help, even if the help is related to a PRs code, should not be done in the comments of the PR if the PR is Merged or Closed. Because this PR is Merged, it doesn't show up as something that needs to be worked on, so your comment would just disappear if I hadn't noticed the notification.