Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #1844

Merged
merged 89 commits into from Nov 21, 2020
Merged

Fix deprecation warnings #1844

merged 89 commits into from Nov 21, 2020

Conversation

KronicDeth
Copy link
Owner

Changelog

Enhancements

  • Make plugin updatable without a restart when installing from the JetBrains Marketplace. (If installing from file on GitHub you still need to restart due to a limitation in the JetBrains API.). JetBrains refers to this as a Dyanmic Plugin.
    • Convert DepsWatcher from project component to project listener
    • Convert Watcher from module component to project listener
    • Make org.elixir_lang.packageManager extension point dynamic
  • Remove unnecessary assert.

Bug Fixes

  • Fix deprecation warnings for IntelliJ IDEA 2020.2
    • Replace fileTypeFactory extensions with fileType
    • Convert fileTypes to Kotlin
    • Replace uses of deprecated Project#baseDir
    • Replace uses of deprecated ContainerUtil.newHashMap
    • Replace defaultLiveTemplatesProvider with defaultLiveTemplates
  • Fix error reporting formatting
    • Fix new lines around excerpts so that code blocks quote correctly
    • Use FILE:LINE format for excerpt location, so it can be used in editors for rapid lookup.
    • Separate title from message
    • Remove use of ErrorBean
    • Pass project for LevelPropertyPusher DumbModeTask
    • Don't use constructor injection for SetupSDKNotificationProvider
    • Don't use AnnotationHolder::create* APIs and use AnnotationBuilder instead.
      • Convert Annotators to Kotlin
    • Use logger.error directly instead of LogMessageEx
    • spaceExistanceTypeBetweenTokens replaced with spaceExistenceTypeBetweenTokens
    • Replace ListCellRendererWrapper with SimpleListCellRenderer
    • Replace StdFileTypes.PLAIN_TEXT with FileTypes.PLAIN_TEXT
    • Replace LanguageSubstitutors.INSTANCE with getInstance()
    • Replace ReportMessages.ERROR_REPORT with ReportMessages.getErrorReport()
    • Replace DefaultProgramRunner with GenericProgramRunner
      • Have only one runner for all configurations in plugin since body of runner was all the same for non-debug.
    • Don't override deprecated flushBufferBeforeTerminating()
    • Don't override deprecated acceptsFile
    • Override initExtra(Project) instead of initExtra(Project, MessageBus, Engine)
    • Replace NamedFoldingDescriptor with FoldingDescriptor
      • Convert folding.Builder to Kotlin
    • Replace file with value for @Storage annotation
    • Replace checkBox(fieldName, title) with checkBox(title, getter, setter)
    • Replace com.intellij.util.contains.Predicate with java.util.function.Predicate
    • Replace CodeStyleSettingsManager with CodeStyle
    • Replace Comparing.equal with Objects.equals
  • Fix Atom annotator to only annotator within current element.
    Annotation keyword pair's key and colon instead of annotating the keyword key and the colon outside of it.
  • Fix ifAccessToString
    I missed taking the 3rd element of the tuple to get [Access, :get] and was checking the outer tuple directly.
    • Convert beam.assembly.ParserDefinition to Kotlin

@KronicDeth KronicDeth added this to the 11.8.1 milestone Oct 30, 2020
@KronicDeth KronicDeth self-assigned this Oct 30, 2020
@KronicDeth KronicDeth modified the milestones: 11.8.1, 11.9.0 Oct 30, 2020
@KronicDeth KronicDeth merged commit cac8ff5 into master Nov 21, 2020
@KronicDeth KronicDeth deleted the updates branch November 21, 2020 03:10
KronicDeth added a commit that referenced this pull request Jan 15, 2021
Fixes #1871

`DepsWatcher` was converted to a Project Listener in #1844 to support installing the plugin from the Marketplace without reloading, but some references to `DepsWatcher` were still trying to get its instance for project using `project.getComponent()`, which would now return `null`.
KronicDeth added a commit that referenced this pull request Jan 15, 2021
Fixes #1871

`DepsWatcher` was converted to a Project Listener in #1844 to support installing the plugin from the Marketplace without reloading, but some references to `DepsWatcher` were still trying to get its instance for project using `project.getComponent()`, which would now return `null`.
KronicDeth added a commit that referenced this pull request Jan 15, 2021
Fixes #1871

`DepsWatcher` was converted to a Project Listener in #1844 to support installing the plugin from the Marketplace without reloading, but some references to `DepsWatcher` were still trying to get its instance for project using `project.getComponent()`, which would now return `null`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant