Skip to content

Commit

Permalink
All dates will now be stored in UTC, rather than local
Browse files Browse the repository at this point in the history
  • Loading branch information
dcramer committed Jan 16, 2012
1 parent 2c12558 commit f61dd7c
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 11 deletions.
4 changes: 2 additions & 2 deletions sentry/manager.py
Expand Up @@ -110,7 +110,7 @@ def get_chart_data(self, instance, max_days=90):
return []

hours = max_days * 24
today = datetime.datetime.now().replace(microsecond=0, second=0, minute=0)
today = datetime.datetime.utcnow().replace(microsecond=0, second=0, minute=0)
min_date = today - datetime.timedelta(hours=hours)

method = self._get_date_trunc('date', db)
Expand Down Expand Up @@ -235,7 +235,7 @@ def from_kwargs(self, project, **kwargs):
logger_name = kwargs.pop('logger', 'root')
server_name = kwargs.pop('server_name', None)
site = kwargs.pop('site', None)
date = kwargs.pop('timestamp', None) or datetime.datetime.now()
date = kwargs.pop('timestamp', None) or datetime.datetime.utcnow()
extra = kwargs.pop('extra', None)
modules = kwargs.pop('modules', None)

Expand Down
2 changes: 1 addition & 1 deletion sentry/queue/tasks/cleanup.py
Expand Up @@ -32,7 +32,7 @@ def cleanup(days=30, logger=None, site=None, server=None, level=None,
# TODO: we should collect which messages above were deleted
# and potentially just send out post_delete signals where
# GroupedMessage can update itself accordingly
ts = datetime.datetime.now() - datetime.timedelta(days=days)
ts = datetime.datetime.utcnow() - datetime.timedelta(days=days)

# Message
qs = SkinnyQuerySet(Event).filter(datetime__lte=ts)
Expand Down
2 changes: 1 addition & 1 deletion sentry/scripts/runner.py
Expand Up @@ -159,7 +159,7 @@ def main():
raise ValueError("Configuration file does not exist. Use 'init' to initialize the file.")

environment['config'] = config_path
environment['start_date'] = datetime.datetime.now()
environment['start_date'] = datetime.datetime.utcnow()

settings_from_file(config_path)

Expand Down
2 changes: 1 addition & 1 deletion sentry/templatetags/sentry_helpers.py
Expand Up @@ -166,7 +166,7 @@ def timesince(value):
from django.template.defaultfilters import timesince
if not value:
return _('Never')
if value < datetime.datetime.now() - datetime.timedelta(days=5):
if value < datetime.datetime.utcnow() - datetime.timedelta(days=5):
return value.date()
value = (' '.join(timesince(value).split(' ')[0:2])).strip(',')
if value == _('0 minutes'):
Expand Down
1 change: 1 addition & 0 deletions sentry/utils/models.py
Expand Up @@ -6,6 +6,7 @@
:license: BSD, see LICENSE for more details.
"""

import datetime
import base64
import logging
import operator
Expand Down
2 changes: 1 addition & 1 deletion sentry/web/frontend/events.py
Expand Up @@ -44,7 +44,7 @@ def event_list(request, project):
offset = (page - 1) * settings.MESSAGES_PER_PAGE
limit = page * settings.MESSAGES_PER_PAGE

today = datetime.datetime.now()
today = datetime.datetime.utcnow()

has_realtime = False

Expand Down
2 changes: 1 addition & 1 deletion sentry/web/frontend/groups.py
Expand Up @@ -185,7 +185,7 @@ def group_list(request, project, view_id=None):
sort = DEFAULT_SORT_OPTION
sort_label = _get_sort_label(sort)

today = datetime.datetime.now()
today = datetime.datetime.utcnow()

has_realtime = page == 1

Expand Down
4 changes: 2 additions & 2 deletions tests/http/tests.py
Expand Up @@ -63,7 +63,7 @@ def test_unicode_keys(self):
self.assertEquals(instance.site, 'not_a_real_site')

def test_timestamp(self):
timestamp = datetime.datetime.now() - datetime.timedelta(hours=1)
timestamp = datetime.datetime.utcnow() - datetime.timedelta(hours=1)
kwargs = {u'message': 'hello', 'timestamp': timestamp.strftime('%s.%f')}
resp = self._postWithSignature(kwargs)
self.assertEquals(resp.status_code, 200, resp.content)
Expand All @@ -75,7 +75,7 @@ def test_timestamp(self):
self.assertEquals(group.last_seen, timestamp)

def test_timestamp_as_iso(self):
timestamp = datetime.datetime.now() - datetime.timedelta(hours=1)
timestamp = datetime.datetime.utcnow() - datetime.timedelta(hours=1)
kwargs = {u'message': 'hello', 'timestamp': timestamp.strftime('%Y-%m-%dT%H:%M:%S.%f')}
resp = self._postWithSignature(kwargs)
self.assertEquals(resp.status_code, 200, resp.content)
Expand Down
4 changes: 2 additions & 2 deletions tests/tests.py
Expand Up @@ -126,7 +126,7 @@ def test_valid_only_message(self):

def test_valid_timestamp_with_tz(self):
with self.Settings(USE_TZ=True):
date = datetime.datetime.now().replace(tzinfo=pytz.utc)
date = datetime.datetime.utcnow().replace(tzinfo=pytz.utc)
event = Group.objects.from_kwargs(1, message='foo', timestamp=date)
self.assertEquals(event.message, 'foo')
self.assertEquals(event.project_id, 1)
Expand All @@ -135,7 +135,7 @@ def test_valid_timestamp_with_tz(self):
def test_valid_timestamp_without_tz(self):
# TODO: this doesnt error, but it will throw a warning. What should we do?
with self.Settings(USE_TZ=True):
date = datetime.datetime.now()
date = datetime.datetime.utcnow()
event = Group.objects.from_kwargs(1, message='foo', timestamp=date)
self.assertEquals(event.message, 'foo')
self.assertEquals(event.project_id, 1)
Expand Down

0 comments on commit f61dd7c

Please sign in to comment.