Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error: global flags not at the start of the expression at position 1 #426

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

omit66
Copy link

@omit66 omit66 commented Nov 3, 2022

PyScss stopped working for python311.

From https://docs.python.org/3.11/whatsnew/3.11.html :

In re Regular Expression Syntax, global inline flags (e.g. (?i)) can now only be used at the start of regular expressions. Using them elsewhere has been deprecated since Python 3.6. (Contributed by Serhiy Storchaka in bpo-47066.)

The issue occurs in one pattern of the class scss.grammar.expression.SassExpressionScanner.

@lswainemoore
Copy link

just ran into this myself--thanks for putting together a solution. wonder what the process for getting this merged is.

@tgherzog
Copy link

tgherzog commented Jan 1, 2023

+1 on the fix - works great. Hope for a merge and update soon!

@glyph
Copy link

glyph commented Feb 14, 2023

Just hit this as well. Is there anything to be done to expedite this merge?

@tgherzog
Copy link

tgherzog commented Feb 14, 2023

His profile says that eOne is based in Kharkiv, so I imagine merges might not be the highest priority for him at the moment. @Kronuz is there anyone else that can respond to a pull request?

@carlosvega
Copy link

Yes, it would be great to merge this and release a new version

@jondricek
Copy link

@Kronuz and/or @e0ne do you have any plans to merge this into master and release a new version of pyScss?

@Kronuz Kronuz merged commit 73559d0 into Kronuz:master Apr 14, 2023
@Kronuz
Copy link
Owner

Kronuz commented Apr 14, 2023

Sorry, I don't have too much time to work on pyScss laterly. Merged the pull request, but I wish there was a way to have continuous releases from GitHub, does anyone know if that's possible to set up, somehow?

@omit66
Copy link
Author

omit66 commented Apr 16, 2023

@Kronuz Maybe you could use GitHub actions to build and published your new releases? Have a Look at gh-action-pypi-publish.

@shwoodard
Copy link

@Kronuz please, pretty please release v1.4.1.

@jondricek
Copy link

Here is a repository I manage that automatically publishes to PyPI from the repo whenever a tag is pushed. It also runs flake8 to lint on every push, regardless if it is tagged. It uses gh-action-pypi-publish like @omit66 suggests. I'd be happy to make a pull request with something like this, but it would still require @Kronuz to setup his PyPI account's PYPI_API_TOKEN as a variable in the repository settings before it would actually work.

https://github.com/mitre-attack/mitreattack-python/blob/master/.github/workflows/lint-publish.yml

Zash added a commit to Zash/snikket-web-portal that referenced this pull request Aug 2, 2023
Because Kronuz/pyScss#426 is not yet in a
release, also just look at the diffstat!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants