Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a configuration service to store library config instead of passing tons of @Inputs #180

Closed
Ks89 opened this issue Jan 26, 2019 · 2 comments
Closed

Use a configuration service to store library config instead of passing tons of @Inputs #180

Ks89 opened this issue Jan 26, 2019 · 2 comments
Assignees
@Ks89
Labels
comp:client comp:testing effort3:hard (weeks) priority:veryhigh type:feature
Milestone
7.3.0

Comments

@Ks89
Copy link
Owner

Ks89 commented Jan 26, 2019

I'm working on develop branch to add a config service to configure all subcomponents of the library.
This change will be totally transparent for you, but for me is really important to be able to implement other cool features in 8.0.0.

It's quite difficult, so I need at least a month, in particular to rewrite tests.

At the end of February I'll add an issue to explain what I'll add in 8.0.0 and the official scheduling.
@Ks89 Ks89 added this to the 7.3.0 milestone Jan 26, 2019
@Ks89 Ks89 self-assigned this Jan 26, 2019
@Ks89 Ks89 changed the title Use a configuration service to store library config instead of passing tons of inputs [7.3.0] Use a configuration service to store library config instead of passing tons of inputs Jan 26, 2019
@Ks89 Ks89 changed the title [7.3.0] Use a configuration service to store library config instead of passing tons of inputs [RELEASE 7.3.0 WIP] Use a configuration service to store library config instead of passing tons of inputs Jan 26, 2019
@Ks89 Ks89 changed the title [RELEASE 7.3.0 WIP] Use a configuration service to store library config instead of passing tons of inputs [RELEASE 7.3.0 WIP] Use a configuration service to store library config instead of passing tons of @Inputs Jan 26, 2019
@Ks89 Ks89 changed the title [RELEASE 7.3.0 WIP] Use a configuration service to store library config instead of passing tons of @Inputs [RELEASE 7.3.0 WIP] Use a configuration service to store library config instead of passing tons of @Inputs Jan 26, 2019
@Ks89 Ks89 pinned this issue Jan 26, 2019
Ks89 added a commit that referenced this issue Jan 27, 2019
@Ks89
feat(): many improvements to configService for carousel #180
e2beb43
Ks89 added a commit that referenced this issue Jan 27, 2019
@Ks89
fix(): many fixes to carousel and carousel-previews about configService
cf33e80 
#180
Ks89 added a commit that referenced this issue Jan 31, 2019
@Ks89
fix(): fix hide/show arrows #180
b1ac791
Ks89 added a commit that referenced this issue Jan 31, 2019
@Ks89
feat(): re-enable modal-gallery in carousel #180
7fd849b
Ks89 added a commit that referenced this issue Feb 10, 2019
@Ks89
fix(): fix previews responsiveness #180
b857223
Ks89 added a commit that referenced this issue Feb 12, 2019
@Ks89
fix(): fix custom previewConfig applying the right default value to p…
0d44168 
…reviewConfig.number #180
Ks89 added a commit that referenced this issue Feb 12, 2019
@Ks89
fix(): add keyboardConfig to config.service.ts #180
b0a87a9
@Ks89
Copy link
Owner Author

Ks89 commented Feb 14, 2019 •
edited
Loading

The first implementation is finished. I also added a bonus feature to this release to be able to download images also as base64.

Everything is still experimental and must be tested on all browsers. So, I'll release in the final version only features that are working with all browsers.

PS: I have to rewrite a huge amount of unit tests, so please be patient.

Ks89 added a commit that referenced this issue Feb 17, 2019
@Ks89
fix(): fix some tests #180
d90bd4b
Ks89 added a commit that referenced this issue Feb 23, 2019
@Ks89
feat(): update carousel main demo #180
5067db8
Ks89 added a commit that referenced this issue Feb 23, 2019
@Ks89
feat(): update all examples #180
1c200b9
Ks89 added a commit that referenced this issue Feb 23, 2019
@Ks89
feat+fix(): all tests upgraded to the new config service - also fix b…
0f08712 
…ug if slideConfig is undefined, sidePreviews should be shown (found thanks to unit testing) #180
@Ks89
Copy link
Owner Author

Ks89 commented Feb 23, 2019

Unit tests completed. Finally I'm ready to release 7.3.0-rc.1.
Issue closed.

@Ks89 Ks89 closed this as completed Feb 23, 2019
@Ks89 Ks89 changed the title [RELEASE 7.3.0 WIP] Use a configuration service to store library config instead of passing tons of @Inputs Use a configuration service to store library config instead of passing tons of @Inputs Feb 23, 2019
@Ks89 Ks89 unpinned this issue Feb 23, 2019
Ks89 added a commit that referenced this issue May 29, 2019
@Ks89
feat(): many improvements to configService for carousel #180
a139b5b
Ks89 added a commit that referenced this issue May 29, 2019
@Ks89
fix(): many fixes to carousel and carousel-previews about configService
7c249d9 
#180
Ks89 added a commit that referenced this issue Jan 1, 2020
@Ks89
feat(): many improvements to configService for carousel #180
1b5fe5e
Ks89 added a commit that referenced this issue Jan 1, 2020
@Ks89
feat(): update all examples #180
57d5dae
Ks89 added a commit that referenced this issue Jan 1, 2020
@Ks89
feat(): update all examples #180
7e42627
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
feat(): many improvements to configService for carousel #180
c6a9d3b
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
fix(): many fixes to carousel and carousel-previews about configService
35aeac1 
#180
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
fix(): fix hide/show arrows #180
322fbd7
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
feat(): re-enable modal-gallery in carousel #180
98a9af4
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
fix(): fix previews responsiveness #180
df59e5c
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
fix(): fix custom previewConfig applying the right default value to p…
30ecd47 
…reviewConfig.number #180
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
fix(): add keyboardConfig to config.service.ts #180
c2e6cf3
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
fix(): fix some tests #180
b420b3c
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
feat(): update carousel main demo #180
8d8b186
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
feat(): update all examples #180
cd4bbde
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
feat+fix(): all tests upgraded to the new config service - also fix b…
d5fdeeb 
…ug if slideConfig is undefined, sidePreviews should be shown (found thanks to unit testing) #180
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
feat(): many improvements to configService for carousel #180
0a2b8a2
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
feat(): update all examples #180
9efb25f
Ks89 added a commit that referenced this issue Oct 3, 2020
@Ks89
feat(): update all examples #180
b6fa834
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
feat(): many improvements to configService for carousel #180
1dde5b5
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
fix(): many fixes to carousel and carousel-previews about configService
240a992 
#180
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
fix(): fix hide/show arrows #180
9f1fce9
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
feat(): re-enable modal-gallery in carousel #180
3643896
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
fix(): fix previews responsiveness #180
a8c5226
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
fix(): fix custom previewConfig applying the right default value to p…
6769ccb 
…reviewConfig.number #180
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
fix(): add keyboardConfig to config.service.ts #180
933a352
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
fix(): fix some tests #180
fb7e76c
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
feat(): update carousel main demo #180
b40e90c
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
feat(): update all examples #180
d249ab6
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
feat+fix(): all tests upgraded to the new config service - also fix b…
8592700 
…ug if slideConfig is undefined, sidePreviews should be shown (found thanks to unit testing) #180
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
feat(): many improvements to configService for carousel #180
8c7098a
Ks89 added a commit that referenced this issue Dec 5, 2020
@Ks89
feat(): update all examples #180
80d8ec7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ks89 Ks89

Labels
comp:client comp:testing effort3:hard (weeks) priority:veryhigh type:feature
Projects
None yet
Milestone
7.3.0
Development

No branches or pull requests
1 participant
@Ks89