Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set fallback image #194

Closed
sm-g opened this issue Sep 27, 2019 · 2 comments
Closed

Ability to set fallback image #194

sm-g opened this issue Sep 27, 2019 · 2 comments

Comments

@sm-g
Copy link

sm-g commented Sep 27, 2019

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x ] Feature request
[ ] Documentation issue or request
[ ] Support request

Current behavior

When ModalImage.img or PlainImage.img points to url, returning 404, the default browser fallback image shown in place of PlainImage and still loading spinner in place of ModalImage.

Expected behavior

Ability to set fallback image, i.e. to configure onerror of <img>:

onerror="this.src='error.jpg';this.onerror='';"

Environment


- @ks89/angular-modal-gallery version: 7.2.1
- Operating System and version:  Windows
- I'm using Server Side Rendering with angular-universal: NO
- I'm compiling with mode: DEBUG



Browser:
- [ x] Any
@Ks89
Copy link
Owner

Ks89 commented Sep 27, 2019

Interesting idea.

@Ks89
Copy link
Owner

Ks89 commented Apr 11, 2020

Feature implemented and scheduled for angular-modal-gallery 8.0.0-beta.1 that is coming soon.
I pushed all commits into branch 800.

I'm sorry for the big delay, but version 8, required a huge effort.

Issue closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants