Aligned Scintilla and build SDK to the latest Notepad++ #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I agree! This great plugin is one of the main reasons I use Notepad++, so thanks for your fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @KubaDee,
I like the plugin for log viewing, unfortunately I have instant crash with the latest versions of Notepad++
Tried to debug it, looked like weird stuff with pointer conversions. After reviewing the code I figured it might be the scintilla interface misalignment. I've copied
scintilla/includefrom the Notepad++ master, and recompiled the plugin. Worked nicely for me.I've also set the build defaults to VS2019, v142. I hope it's fine. It seems that's how the main application is built.
Would be great if we can have it released so I can have it through the plugin manager :)
Cheers,
Błażej