-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parameters to VoxelMap.msg #151
Conversation
Checks seem to be failing. This is a problem on our end. |
I very much hope that JPS does not depend on planning_ros_msgs. |
Here are a few high-level points:
This task is highly non-trivial, you need to look into many files in JPS/MPL to understand how things work. Once the tests are in place, you can then proceed to make these voxel values (val_occ,...) input parameters to functions like setMap()
|
@ankit16-py please fetch, rebase on |
Good point, I will do this after I merge the other PR. |
62da343
to
af7bd09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I am going to test it before approving.
Approving the changes now, but Chao's suggestions need to be considered, probably we will create a new PR for this. |
Added the variables,
val_occ, val_even, val_unknown, val_free, val_add and val_default
toVoxelMap.msg
file with their default value. Subsequently replaced hard-codings of all these variables inmap_utils.h
files of thempl
andjps3d
packages,voxel_mapper.h
file frommapper
package andglobal_plan_server.cpp
andlocal_plan_server.cpp
files fromaction_planner
package