Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from MBZIRC development #88

Closed
wants to merge 81 commits into from
Closed

Updates from MBZIRC development #88

wants to merge 81 commits into from

Conversation

justinthomas
Copy link
Contributor

No description provided.

Note: I removed the mass argument since it is set in the
hummingbird_params.yaml file and should be able to be different than the
mass that the controllers are using.
Conflicts:
	mav_manager/src/manager.cpp
Conflicts:
	mavros_interface/src/mavros_interface_nodelet.cpp
* feature/so3_control_dynamic_reconfigure:
  Fix scope issue
  Add dynamic reconfigure to so3_control_nodelet

# Conflicts:
#	so3_control/CMakeLists.txt
#	so3_control/src/so3_control_nodelet.cpp
* feature/so3_control_dynamic_reconfigure:
  Increase max integrals
  Duplication fix, and more specific digits

# Conflicts:
#	so3_control/src/so3_control_nodelet.cpp
* master:
  Install quadrotor_simulator config folder
  mavros_interface: Add mavros_msgs_INCLUDE_DIRS to CMakeLists.txt
  mavros_interface: Only warn when psi check fails, don't set throttle = 0
  mavros_interface: Add a num_props param, change kf to per prop value
  Update asio_serial_device submodule
  quadrotor_msgs: "DEPENDS eigen" -> "DEPENDS Eigen" in CMakeLists.txt
  Some big changes to so3_control (#86)
  Add safety checks in mav manager (#82)
  Initialize publishers before subscribers

# Conflicts:
#	so3_control/config/gains.yaml
#	so3_control/include/so3_control/SO3Control.h
#	so3_control/src/SO3Control.cpp
#	so3_control/src/so3_control_nodelet.cpp
* feature/so3_control_dynamic_reconfigure:
  Reconfigure almost everything in so3_control
  Remove Extra Lines

# Conflicts:
#	so3_control/cfg/SO3.cfg
#	so3_control/src/so3_control_nodelet.cpp
* commit 'ec5c7dbbb4f03681afd5c97f83afc21d586e0e73':
  Fix warning for unknown level
  Use dynamic_reconfigure level correctly as bitmask per discussion in #88
  Interface to so3_control to ensure continuous gain changes
  Ignore CATKIN_IGNORE
* feature/so3_control_dynamic_reconfigure:
  Better integral limits in cfg file
* feature/so3_control_dynamic_reconfigure:
  Add parameters for Gains Filter
@tdinesh tdinesh mentioned this pull request Aug 10, 2019
8 tasks
@tdinesh tdinesh marked this pull request as draft April 21, 2020 23:36
@tdinesh
Copy link
Collaborator

tdinesh commented Apr 28, 2020

@kartikmohta Anything useful in this? Is it worth the effort to resolve conflicts?

Useful updates:

  • SetMass for changing payload on the fly
  • geometry_msgs/Vector3 snap in PositionCommand (Does any of our current interfaces consume snap? )

Maybe FLA has more important updates to mavros_interface?

@tdinesh tdinesh closed this Apr 28, 2020
@kartikmohta
Copy link
Collaborator

@kartikmohta Anything useful in this? Is it worth the effort to resolve conflicts?

Useful updates:

* SetMass for changing payload on the fly

* geometry_msgs/Vector3 snap in PositionCommand (Does any of our current interfaces consume snap? )

Maybe FLA has more important updates to mavros_interface?

  • The set mass might be useful, but fairly easy to implement now that we have the so3_control reconfigure.
  • I think snap is only useful when doing very aggressive motions, like flips, nothing uses it right now.
  • I don't remember if FLA has any big changes to mavros_interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants