Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template settings for BBCode are ineffective #7774

Closed
Ruud68 opened this issue Dec 21, 2020 · 9 comments · Fixed by #7801 or #7808
Closed

Template settings for BBCode are ineffective #7774

Ruud68 opened this issue Dec 21, 2020 · 9 comments · Fixed by #7801 or #7808
Milestone

Comments

@Ruud68
Copy link
Contributor

Ruud68 commented Dec 21, 2020

Describe the bug

To Reproduce
in template settings tab [bbcode] configure the following settings to 'no'

  • Show Twitter button
  • Show Ebay button
  • Show Instagram button
  • Show Soundcloud button

Expected behavior
buttons not showing in editor

Actual result
buttons showing in editor

Screenshots
If applicable, add screenshots to help explain your problem.
image

System information (please complete the following information)

Joomla version: 3.9.23
Kunena version: 5.2
Kunena template name and version: crypsis
Php version: 7.4

@xillibit xillibit added this to the 5.2 milestone Dec 21, 2020
@xillibit xillibit added the 5.2 label Dec 21, 2020
@rich20 rich20 changed the title cannot remove insta, twitter, soundcloud, ebay buttons in editor Template settings for BBCode are ineffective Dec 21, 2020
@rich20
Copy link
Member

rich20 commented Dec 21, 2020

@Ruud68
It should be possible by adding names of the buttons in the ckeditor_config.js
.../media/kunena/core/js/ckeditor_config.js lines 33 until 43

In the template setting (tab BBCode) are this options (no one of these buttons can be deactivated)

Maybe we should remove this setting options (except the social share buttons)? Or we keep these options, but then they should work.

  • Show Video button
  • Show Maps button
  • Show Emoticons button
  • Show Twitter button
  • Show Ebay button
  • Show Link button
  • Show Picture button
  • Show Hide button
  • Show Spoiler button
  • Show Table button - can be removed (tables do not work with CKEditor)
  • Show Code button
  • Show Quote button
  • Show Instagram button
  • Show Soundcloud button
  • Show Confidential button
  • Show Superscript button
  • Show Subscript button
  • Show Numbering button
  • Show Bullets button
  • Show Align Right button
  • Show Center button
  • Show Underline button
  • Show Italic button
  • Show Bold button
  • Show Strikethrough button
  • Show Colors drop menu
  • Show Size drop menu - is available four times
  • Show Size drop menu
  • Show Size drop menu
  • Show Size drop menu

@rich20 rich20 added the enhance label Dec 21, 2020
@Ruud68
Copy link
Contributor Author

Ruud68 commented Dec 23, 2020

Hi @rich20 , thanks for looking into this.
This is okay for a temp solution, but as this is a Kunena 'core' hack, any changes will not survive a Kunena upgrade. So the setting in the template should be pulled in by this js file and removed when configured to do so.

I'm still undecided if I want the new editor (not that there is a choice), as the editor as it is now is to 'bloated': on a mobile the editor buttons take half the edit screen which is not okay.
Is that something that will be looked at or is that as it will be 'forever' ?

@rich20
Copy link
Member

rich20 commented Dec 23, 2020

Yes, it was only a temporary solution for you. The setting options muss be fixed.
I don't know the reason for changing to CKEditor, but he will remain I think. I've added now the bug label.

I'm still undecided if I want the new editor (not that there is a choice), as the editor as it is now is to 'bloated': on a mobile the editor buttons take half the edit screen which is not okay.

Yes, I noticed that. A lot of space is wasted by the order of the symbols.
Bildschirmfoto von 2020-12-23 18-40-21

@rich20 rich20 added the bug label Dec 23, 2020
@Ruud68
Copy link
Contributor Author

Ruud68 commented Dec 26, 2020

CKEditors added value (for me) is WYSIWYG, the bb-code that was showing in the text makes it 'unusable' for not-so-nerdy users :) This is definitely an improvement, although moving from bb-code to HTML would IMO even be a better option as that way you can have a choice of editor inline with the rest of your site.
Would definitely be my choice when starting-over. conversion from old posts bb-code could be handled by an import or even on the fly with a plugin.

@Ruud68
Copy link
Contributor Author

Ruud68 commented Dec 28, 2020

not fixed, please reopen.
All settings are still there and not working

@xillibit
Copy link
Member

For me it has worked with that change on crypsis

@xillibit xillibit reopened this Dec 28, 2020
@Ruud68
Copy link
Contributor Author

Ruud68 commented Dec 28, 2020

Version 5.2.1.
Also none of the settings are working (e.g. switching confidential = no, displays the confidential button)
image

@rich20
Copy link
Member

rich20 commented Dec 28, 2020

Can't be deactivated

  • Show Align Right button
  • Show Textcolor button on editor

@rich20
Copy link
Member

rich20 commented Dec 29, 2020

I think, this can be closed unless you want to make the remaining symbols deactivatable.
Bildschirmfoto von 2020-12-29 15-46-33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants