-
-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Kunena intallation to jQuery for J!3.x series #2671
Conversation
6d81119
to
727cef2
Compare
'3.1' => '3.1.5', | ||
'3.0' => '3.0.4', | ||
'2.5' => '2.5.9', | ||
'0' => '2.5.22' // Preferred version | ||
'0' => '2.5.27' // Preferred version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change to 3.3.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ? K3.0 is still allowed to be installed under J2.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the Preferred version. j2.5 is almost eol. so i think this will be the last J2.5 version. So we need to advice the customers to update to j3.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need to check if it's possible to install under J!2.5, the EOL is set on 31/12/2014 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's correct
installation is done, but the go to kunena button isn't working, close button is working |
} | ||
}); | ||
kunenaRequest.post('<?php echo JSession::getFormToken(); ?>=1'); | ||
|
||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be:
};
jQuery(document).ready(function() {
jQuery('#kunena-toggle').click(function(e) {
jQuery('#kunena-container').toggleClass('hidden');
e.preventDefault();
});
jQuery('#kunena-component').click(function(e) {
window.location.href='<?php echo JRoute::_('index.php?option=com_kunena')?>';
e.preventDefault();
});
jQuery('#kunena-installer').click(function(e) {
window.location.href='#Close';
e.preventDefault();
});
window.kunenainstall();
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, i will check that
could you also add this: #2583
|
I will add in another PR |
96453f6
to
ad55bb7
Compare
ad55bb7
to
d35abd4
Compare
d35abd4
to
3606403
Compare
+1 RTM everything is now jquery, and working |
Convert Kunena intallation to jQuery for J!3.x series
No description provided.