Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Kunena intallation to jQuery for J!3.x series #2671

Merged
merged 2 commits into from
Dec 17, 2014

Conversation

xillibit
Copy link
Member

@xillibit xillibit commented Dec 2, 2014

No description provided.

'3.1' => '3.1.5',
'3.0' => '3.0.4',
'2.5' => '2.5.9',
'0' => '2.5.22' // Preferred version
'0' => '2.5.27' // Preferred version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to 3.3.6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ? K3.0 is still allowed to be installed under J2.5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the Preferred version. j2.5 is almost eol. so i think this will be the last J2.5 version. So we need to advice the customers to update to j3.3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to check if it's possible to install under J!2.5, the EOL is set on 31/12/2014 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's correct

@810
Copy link
Member

810 commented Dec 3, 2014

installation is done, but the go to kunena button isn't working, close button is working

}
});
kunenaRequest.post('<?php echo JSession::getFormToken(); ?>=1');


}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be:

 };
    jQuery(document).ready(function() {
        jQuery('#kunena-toggle').click(function(e) {
            jQuery('#kunena-container').toggleClass('hidden');
            e.preventDefault();
        });
        jQuery('#kunena-component').click(function(e) {
            window.location.href='<?php echo JRoute::_('index.php?option=com_kunena')?>';
            e.preventDefault();
        });
        jQuery('#kunena-installer').click(function(e) {
            window.location.href='#Close';
            e.preventDefault();
        });
        window.kunenainstall();
    }); 

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i will check that

@810
Copy link
Member

810 commented Dec 3, 2014

could you also add this: #2583
administrator\components\com_kunena\install\model.php line 58

 if (ini_get('ignore_user_abort')) {
            ignore_user_abort ( true );
        }

@xillibit
Copy link
Member Author

xillibit commented Dec 3, 2014

could you also add this: #2583
administrator\components\com_kunena\install\model.php line 58

if (ini_get('ignore_user_abort')) {
ignore_user_abort ( true );
}

I will add in another PR

@810
Copy link
Member

810 commented Dec 17, 2014

+1 RTM everything is now jquery, and working

xillibit added a commit that referenced this pull request Dec 17, 2014
Convert Kunena intallation to jQuery for J!3.x series
@xillibit xillibit merged commit 9b180e2 into Kunena:master Dec 17, 2014
@xillibit xillibit deleted the juqey_install branch December 17, 2014 20:57
@mahagr mahagr added this to the 3.0.7 milestone Dec 30, 2014
@mahagr mahagr added the bug label Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants