Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K3.1] Crypsis: Online Status Crypsis feature #2783

Merged
merged 14 commits into from
Mar 4, 2015
Merged

[K3.1] Crypsis: Online Status Crypsis feature #2783

merged 14 commits into from
Mar 4, 2015

Conversation

810
Copy link
Member

@810 810 commented Feb 18, 2015

This is the new online status feature created by Josh. But updated to lasted version, + fixes some issue's

The other feature pr, needed merged before this pr can be pulled.

@810 810 added this to the 3.1.0 milestone Feb 18, 2015
@810 810 mentioned this pull request Feb 18, 2015
Closed
xillibit
xillibit reviewed Feb 20, 2015
View reviewed changes
components/com_kunena/site/controllers/user.php
@@ -331,6 +331,41 @@ function logout() {
$this->setRedirectBack();
}

public function status() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new code added doesn't follow Joomla! coding standards

@xillibit
Copy link
Member

There seem to be conflict in the code now

xillibit
xillibit reviewed Feb 21, 2015
View reviewed changes
components/com_kunena/site/controllers/user.php
}
else
{
$this->app->enqueueMessage(JText::_('Successfully Saved Status Text'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing language string here

@xillibit
Copy link
Member

I have an issue : Rendering Error in layout Widget/Modal: Property "class" is not defined in C:\wamp\www\joomla3.3.6\components\com_kunena\template\crypsis\layouts\widget\modal\default.php on line 17
Layout was rendered in C:\wamp\www\joomla3.3.6\components\com_kunena\template\crypsis\layouts\widget\login\logout\default.php on line 158

@810
Copy link
Member Author

810 commented Feb 27, 2015

any suggestion to fix this?

@xillibit
Copy link
Member

What should be the default value into $this->class here (the file is \components\com_kunena\template\crypsis\layouts\widget\modal\default.php) :

$class = ' class="modal' .$state . $transition . $this->class.'"';

?

@810
Copy link
Member Author

810 commented Feb 27, 2015

i have removed it, please try now

@xillibit
Copy link
Member

Others issues noticied :

Rendering Error in layout Widget/Modal: Property "form" is not defined in C:\wamp\www\joomla3.3.6\components\com_kunena\template\crypsis\layouts\widget\modal\default.php on line 22
Layout was rendered in C:\wamp\www\joomla3.3.6\components\com_kunena\template\crypsis\layouts\widget\login\logout\default.php on line 159

To fix one above add line 158 ->set('form', 'statusText-form') into \components\com_kunena\template\crypsis\layouts\widget\login\logout\default.php

Rendering Error in layout Widget/Label: Property "class" is not defined in C:\wamp\www\joomla3.3.6\components\com_kunena\template\crypsis\layouts\widget\label\link.php on line 17
Layout was rendered in C:\wamp\www\joomla3.3.6\components\com_kunena\template\crypsis\layouts\user\item\status\default.php on line 47

Missing language strings into \components\com_kunena\template\crypsis\layouts\widget\login\logout\default.php lines 155 to 157

@810
Copy link
Member Author

810 commented Feb 27, 2015

try now

@xillibit
Copy link
Member

Better but this one isn't fixed :

`Rendering Error in layout Widget/Label: Property "class" is not defined in C:\wamp\www\joomla3.3.6\components\com_kunena\template\crypsis\layouts\widget\label\link.php on line 17
Layout was rendered in C:\wamp\www\joomla3.3.6\components\com_kunena\template\crypsis\layouts\user\item\status\default.php on line 47

It's enough to remove the $this->class i think in \components\com_kunena\template\crypsis\layouts\widget\label\link.php line 17

@810
Copy link
Member Author

810 commented Feb 27, 2015

ok, removed it everywhere

@xillibit
Copy link
Member

All is good now 👍

810 added a commit that referenced this pull request Mar 4, 2015
@810
Merge pull request #2783 from 810/develop-online
b90d071 
[K3.1] Crypsis: Online Status Crypsis feature
@810 810 merged commit b90d071 into Kunena:develop Mar 4, 2015
@810 810 deleted the develop-online branch March 22, 2015 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@810 @xillibit