Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ajax upload for avatar #3885 (set link on avatar to go to edit) #5443

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

xillibit
Copy link
Member

Pull Request for Issue # .

Summary of Changes

Testing Instructions

@xillibit xillibit added this to the 5.1.0 milestone Jun 25, 2017
@rich20
Copy link
Member

rich20 commented Jun 25, 2017

Not sure if it's ok

  • When user click on avatar, it should go directly to edit profile and open the tab to change avatar (The link goes directly to the profile edit but you need a click on the tab to open the avatar options. For me it's ok.)

@xillibit
Copy link
Member Author

I have modified to make it working too on categories index, do-you have an error on javascript console after to be redirected to profile page ?

@rich20
Copy link
Member

rich20 commented Jun 25, 2017

Not directly a error, but this message I had not before:

jquery.min.js?fc02fca…:4 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

@rich20
Copy link
Member

rich20 commented Jun 25, 2017

jquery.min.js?fc02fca…:4 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.

Sorry, this message comes aso without this fix if you click on Profile -> Edit. So is your fix for me now ok.

@810 810 merged commit 6327a04 into Kunena:K5.1 Jun 27, 2017
@xillibit xillibit deleted the K5.1_bugs10 branch February 1, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants