New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dotted notes, =
lengths and tie support to l
directives
#1
Comments
You're right! A few files were further modified afterwards. I'll get that pushed in. No-go on ties due to a conflict with the actual tie command, which is a valid N-SPC command. I have the = length part implemented on my end, and I haven't gotten to the dotted notes yet. I can compare and contrast on the pull request with my own copy if you want. |
This commit references #1. Tie support for l directive is not implemented here due to a conflict with the actual tie command used by the sound driver itself.
This primairly includes the dotted note and if it were inside a triplet. This commit references #1.
Although I merged the changes, I have not closed the issue yet, pending a confirmation to let the tie portion remain cut. |
I'm adding sound effects to the scope of this issue, because I both never implemented them and there is way more to do there in addition to what this will do. |
Triplets were previously de-facto ignored by the default note length, and factoring them in causes them to be calculated twice by mistake. Because triplets are temporary modifiers due to being defined as a section, unlike dotted notes, they don't need to permanently modify the default note length. This commit closes #214 and mentions #1 due to reverting a change that was breaking existing cases.
This is officially problematic because of the way substitution works. Namely, substitution only works at the start of each character prior to processing anything else and does not account for any characters in between. This results in a quirk where a rest followed by a define that is the same first character as a rest gets lost in the mix because it is combined. This quirk can work in reverse by failing to detect a character as the first character of a macro substitution. Unfortunately, adding the The This kind of problem is going to result in two things:
|
I was redirected here after hearing you were working on this, except didn't want to touch tie support? I would have added it long ago if I had any idea how to get AMK compiling, but I can do you a pull request to add this in, already got the code.
Oh, and side-note, plus a reason why AMK really does need replacing (working on it): you seem to have the AMK 1.0.8 before it was moderated, meaning you haven't imported the actual released 1.0.8 (it was further changed before it passed moderation).
The text was updated successfully, but these errors were encountered: