Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new parser version 4 #278

Closed
5 tasks done
KungFuFurby opened this issue Mar 17, 2022 · 1 comment · Fixed by #279
Closed
5 tasks done

Create new parser version 4 #278

KungFuFurby opened this issue Mar 17, 2022 · 1 comment · Fixed by #279
Labels
c++-side Involves the AddMusicK program itself in some way. documentation Improvements or additions to documentation

Comments

@KungFuFurby
Copy link
Owner

KungFuFurby commented Mar 17, 2022

Citing https://smwc.me/1599381 and the few replies I have received, I will go through with parser version 4.

Parser version 4 will do the following:

All older versions will output warnings for running into the following...

I will also support some of the parser version 3 features as indicated in #216. Anything related to new hex commands will not be covered, and conversions in particular are parser version 3 only.
The following also needs to be done...

@KungFuFurby KungFuFurby added the c++-side Involves the AddMusicK program itself in some way. label Mar 17, 2022
KungFuFurby added a commit that referenced this issue Mar 17, 2022
KungFuFurby added a commit that referenced this issue Mar 17, 2022
This will specifically mention Codec's AddmusicK Beta as the error message.
This commit mentions #278.
KungFuFurby added a commit that referenced this issue Mar 17, 2022
Citing conflicts with substitution, these are now only for parser versions 4 and
up.

This commit closes #278... though more can be added on, this is the bare minimum
that was intended to be done.
@KungFuFurby KungFuFurby moved this from To do to In progress in AddMusicK 1.0.9? Merge TODO List Jun 17, 2022
@KungFuFurby KungFuFurby added the documentation Improvements or additions to documentation label Jun 30, 2022
AddMusicK 1.0.9? Merge TODO List automation moved this from In progress to Done Jul 6, 2022
@KungFuFurby
Copy link
Owner Author

Although #allsamplesimportant and #notranspose could have been implemented from parser version 3 for this parser version, I have instead merged the pull request and closed the issue for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++-side Involves the AddMusicK program itself in some way. documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant