Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bunch of SensioInsights warnings #299

Merged
merged 7 commits into from
Apr 18, 2014
Merged

Fix a bunch of SensioInsights warnings #299

merged 7 commits into from
Apr 18, 2014

Commits on Apr 18, 2014

  1. Remove CKEditor samples

    Roderik van der Veer committed Apr 18, 2014
    Configuration menu
    Copy the full SHA
    3996dbe View commit details
    Browse the repository at this point in the history

  2. Files should not be executable

    Roderik van der Veer committed Apr 18, 2014
    Configuration menu
    Copy the full SHA
    9d9dc99 View commit details
    Browse the repository at this point in the history

  3. Limit the flush action 

    Calling flush is a resource intensive operation, especially when a lot of entities are managed by Doctrine. You should pass the entity you want to flush as parameter, or avoid flushing inside a loop.
    Roderik van der Veer committed Apr 18, 2014
    Configuration menu
    Copy the full SHA
    c44210d View commit details
    Browse the repository at this point in the history

  4. Source code should not contain TODO comments

    Roderik van der Veer committed Apr 18, 2014
    Configuration menu
    Copy the full SHA
    819022f View commit details
    Browse the repository at this point in the history

  5. Commented code should not be commited

    Roderik van der Veer committed Apr 18, 2014
    Configuration menu
    Copy the full SHA
    b554e92 View commit details
    Browse the repository at this point in the history

  6. Unused use statements and variables

    Roderik van der Veer committed Apr 18, 2014
    Configuration menu
    Copy the full SHA
    8c931c2 View commit details
    Browse the repository at this point in the history

  7. code cleanup & refactoring / admin locale migration & fixtures

    @wimvds
    wimvds committed Apr 18, 2014
    Configuration menu
    Copy the full SHA
    8b023d6 View commit details
    Browse the repository at this point in the history