[AdminBundle] OAuthUserCreator Should query on username and email #1154
Conversation
|
I just realised there could be still a problem with this code in the following use case. |
|
Perhaps we should have logic that it first searches for matching email. If not found, also search username. What do you think? |
|
I gave find by email a higher priority as find by username. That way if there are 2 accounts present with that email address the one with the email address in the email field will be chosen. |
|
How about giving the developer a choice? I.e. extract some kind |
jockri
changed the title
|
@mlebkowski following your advice I pulled everything apart and set everything behind interfaces. This should allow other people to override either only the code for finding a user based on the googleId and email address or the complete login procedure. @jockri I think this should be quite ready now |
| * @param string email | ||
| * @param string googleId | ||
| * | ||
| * @return AbstractUser Implementation |
There was a problem hiding this comment.
@return mixed AbstractUser Implementation — this way IDE won’t expect to return AbstractUser instance. Maybe it should be a UserInterface instance from FOS?
When someone signs in for the first time using google sign in, his user should be searched based on email or username. 2 seperate steps find email address in database [AdminBundle] Find by email has higher priority as find by username Abstract all parts oauth login [AdminBundle] Put each part of the login functionality behind an interface and pull each step apart, find user, create user, login user. Expect EntityManagerInterface and mixed AbstractUser in comments
Numkil
changed the title
* master: Video thumbnail fix (#1179) [AdminBundle] fix regex to check if admin preview (#1182) Fix adminlist SimpleItemAction template [AdminListBundle] Updated list template to use an icon for the View link Fix translation (#1177) [AdminBundle] OAuthUserCreator Should query on username and email (#1154) [All bundle] Translation fixes (#1172) Added `update ACL command` to update specific role with given permission(s) for all nodes [ArticleBundle] Added ability to select which overview page to add an article page to (#1160)
When someone signs in for the first time using google sign in, his user should be searched based on
email or username.