[AdminBundle] fix regex to check if admin preview #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jockri
pushed a commit
that referenced
this pull request
Jun 1, 2016
* master: Video thumbnail fix (#1179) [AdminBundle] fix regex to check if admin preview (#1182) Fix adminlist SimpleItemAction template [AdminListBundle] Updated list template to use an icon for the View link Fix translation (#1177) [AdminBundle] OAuthUserCreator Should query on username and email (#1154) [All bundle] Translation fixes (#1172) Added `update ACL command` to update specific role with given permission(s) for all nodes [ArticleBundle] Added ability to select which overview page to add an article page to (#1160)
|
And what if you have a different route altogether? This seems like an ugly hack. Wouldn’t it be better to mark admin routes with a request parameter for an instance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extended the admin/preview check. The check to see if the url contains /admin/preview was not working if you have a preview route like /admin/project/preview