[AdminBundle] Remove ROLE_SUPER_ADMIN role from permissions when user is not an superadmin #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyvw
force-pushed
the
feature/permissions
branch
from
871dedf
to
8d8d605
Compare
dannyvw
changed the title
|
I don't think it is a good idea to change the |
|
Is this something you want in the core? If so.. then we can add a separate method like getManagableRolesForPages and edit the view to use this method. |
|
Yes, that can be added in the core. Just create a new helper function. |
|
@jockri Pull-request is updated |
jockri
pushed a commit
that referenced
this pull request
Jun 20, 2016
* master: [NodeBundle]: add custom form type for node translations [NodeSearchBundle] Change title search + add configuration (#1188) Add new translations (#1190) [AdminBundle] Remove ROLE_SUPER_ADMIN role from permissions when user is not an superadmin (#1170) Fixed wrong translations amdin -> admin MediaBundle] Workaround crash when invalid FileUploadForm not redirecting to correct view Fixed rendering form label class Upgrade CKEditor configuration doc Fixed new window for menu items Make node publish date stepping configurable [SeoBundle] check on twitterImage Added event listeners for user management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ROLE_SUPER_ADMIN role from permissions when user is not an superadmin