Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeSearchBundle] Change title search + add configuration #1188

Merged
merged 3 commits into from
Jun 20, 2016
Merged

[NodeSearchBundle] Change title search + add configuration #1188

merged 3 commits into from
Jun 20, 2016

Conversation

fchris82
Copy link
Contributor

@fchris82 fchris82 commented Jun 6, 2016

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

While we search with "állam" (= state) then get back the title "vállalat" ( = company), because find "álla" in the "vállalat". This is wrong, and we don't want to allow it in some project.

@Numkil
Copy link
Contributor

Numkil commented Jun 7, 2016

This is a good bugfix for now.

However I want to mention that in the next release of our cms we have a big refactoring of the whole Search and NodeSearch bundles coming up. Included in these refactorings we are moving away from using custom analyzers with basic Ngrams to stem words and are going to use the build in language specific analyzers from elasticsearch itself. These will be more intelligent and weird matches like that should not happen again.

@jockri jockri merged commit ff8f398 into Kunstmaan:master Jun 20, 2016
@jockri jockri added this to the 3.5.2 milestone Jun 20, 2016
jockri pushed a commit that referenced this pull request Jun 20, 2016
* master:
  [NodeBundle]: add custom form type for node translations
  [NodeSearchBundle] Change title search + add configuration (#1188)
  Add new translations (#1190)
  [AdminBundle] Remove ROLE_SUPER_ADMIN role from permissions when user is not an superadmin (#1170)
  Fixed wrong translations amdin -> admin
  MediaBundle] Workaround crash when invalid FileUploadForm not redirecting to correct view
  Fixed rendering form label class
  Upgrade CKEditor configuration doc
  Fixed new window for menu items
  Make node publish date stepping configurable
  [SeoBundle] check on twitterImage
  Added event listeners for user management
@fchris82 fchris82 deleted the feature/matchqueryfortitle branch June 21, 2016 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants