-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AllBundles] Postgres compatibility fixes #1778
[AllBundles] Postgres compatibility fixes #1778
Conversation
@Devolicious any chance this can still make it in 5.0? Or will it be moved to the first bugfix on 5.0? |
@acrobat I think that since this is a bugfix that there are 2 options. First option is like you said, wait until V5 has been release and than apply it as a bugfix for 5.0.1. Second option is that we rebase this and submit it to the 4.1 branch. From a safety point of view I like the first option better since we are moving away from V4 and that would mean that if we later found out that something is broken, that 4.1 stays broken since we don't support it anymore than. On the other hand you tested it, tests succeeded, so it would be nice if we could add this to 4.1 as well. |
…s is more strict (more sql compliant) so this fails otherwise
… to be explicitly double-quoted to be case-sensitive so renamed the alias to avoid this.
…ied. Added more fields to be compliant and this also makes it more "safe"
e0ab8de
to
183e948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR needs some changes
- your should rebase your PR so that it only contains 1 commit
- A core contributor should set the correct milestone for this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR needs some changes
- your should rebase your PR so that it only contains 1 commit
- A core contributor should set the correct milestone for this PR
183e948
to
54f4770
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @acrobat, your PR needs some changes
- your should rebase your PR so that it only contains 1 commit
- A core contributor should set the correct milestone for this PR
@Devolicious I've rebased the PR against 4.1, surprisingly no merge conflicts 🎉 💪 So this should be good to go for 4.1. I don't have any bundles 4 projects so only tested on a 5 project but as there were no merge conflicts this should work on all versions. |
* 4.1: update changelog [AllBundles] Postgres compatibility fixes (#1778)
I've started a new project with a postgres database and I got a lot of errors to start with. These fixes are "needed" to be able to use postgres as the backend database. I have tested these fixes with a clean install on mysql and postgres.
The biggest problem was the custom query for the acl check. Other queries don't use db specific stuff of use orm/dbal which is compatible by default.
Summary of the fixes:
false/true
instead of0/1
IF
function, instead it has anCOALESCE
function