-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All Bundles] Added PostgreSQL support #2811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @, your PR needs some changes
- It seems that you should have submitted to the latest minor branch.
- This PR seems to need a milestone of a patch release.
7398da5
to
07a93c6
Compare
…e the query on postgresql
07a93c6
to
8888ac2
Compare
->where('t.online = :online') | ||
->setParameter('online', true) | ||
->andWhere('n.deleted = :deleted') | ||
->setParameter('deleted', false) | ||
->andWhere('v.refEntityName = :refname') | ||
->orderBy('a.date', 'DESC') | ||
->setParameter('refname', "{{ namespace | replace({'\\': '\\\\'}) }}\\Entity\\Pages\\{{ entity_class }}Page"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//// is only required in LIKE clause and should not work with "="
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions. I will also test this PR on some actually projects to avoid any breaks there
e.class_id = o.class_id AND (e.object_identity_id = o.id | ||
OR {$aclConnection->getDatabasePlatform()->getIsNullExpression('e.object_identity_id')}) | ||
) | ||
LEFT JOIN {$databasePrefix}acl_security_identities s ON ( | ||
LEFT JOIN acl_security_identities s ON ( | ||
s.id = e.security_identity_id | ||
) | ||
WHERE c.class_type = {$rootEntity} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.class_id = o.class_id AND (e.object_identity_id = o.id | ||
OR {$aclConnection->getDatabasePlatform()->getIsNullExpression('e.object_identity_id')}) | ||
) | ||
LEFT JOIN {$databasePrefix}acl_security_identities s ON ( | ||
LEFT JOIN acl_security_identities s ON ( | ||
s.id = e.security_identity_id | ||
) | ||
WHERE c.class_type = {$rootEntity} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as comment above
…veHelper and Aclwalker
…r and UserRepository
…nslationAdminlistConfigurator
Based on #1778 and #1810
This PR makes it possible to use Kunstmaan Bundles CMS with a PostgreSQL database.