Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All Bundles] Added PostgreSQL support #2811

Closed
wants to merge 13 commits into from

Conversation

igst
Copy link
Contributor

@igst igst commented Nov 3, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -

Based on #1778 and #1810

This PR makes it possible to use Kunstmaan Bundles CMS with a PostgreSQL database.

Copy link

@ProfessorKuma ProfessorKuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @, your PR needs some changes

  • It seems that you should have submitted to the latest minor branch.
  • This PR seems to need a milestone of a patch release.

->where('t.online = :online')
->setParameter('online', true)
->andWhere('n.deleted = :deleted')
->setParameter('deleted', false)
->andWhere('v.refEntityName = :refname')
->orderBy('a.date', 'DESC')
->setParameter('refname', "{{ namespace | replace({'\\': '\\\\'}) }}\\Entity\\Pages\\{{ entity_class }}Page");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//// is only required in LIKE clause and should not work with "="

Copy link
Member

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions. I will also test this PR on some actually projects to avoid any breaks there

e.class_id = o.class_id AND (e.object_identity_id = o.id
OR {$aclConnection->getDatabasePlatform()->getIsNullExpression('e.object_identity_id')})
)
LEFT JOIN {$databasePrefix}acl_security_identities s ON (
LEFT JOIN acl_security_identities s ON (
s.id = e.security_identity_id
)
WHERE c.class_type = {$rootEntity}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.class_id = o.class_id AND (e.object_identity_id = o.id
OR {$aclConnection->getDatabasePlatform()->getIsNullExpression('e.object_identity_id')})
)
LEFT JOIN {$databasePrefix}acl_security_identities s ON (
LEFT JOIN acl_security_identities s ON (
s.id = e.security_identity_id
)
WHERE c.class_type = {$rootEntity}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as comment above

IntegraConsult added a commit to IntegraConsult/KunstmaanBundlesCMS that referenced this pull request Dec 23, 2020
IntegraConsult added a commit to IntegraConsult/KunstmaanBundlesCMS that referenced this pull request Jan 14, 2021
IntegraConsult added a commit to IntegraConsult/KunstmaanBundlesCMS that referenced this pull request Jan 14, 2021
IntegraConsult added a commit to IntegraConsult/KunstmaanBundlesCMS that referenced this pull request Jan 14, 2021
@acrobat
Copy link
Member

acrobat commented Mar 15, 2021

I'm closing the PR in favor of #2849, the implentation will be finished there. Thanks for your work on this @igst!

@acrobat acrobat closed this Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants