[KunstmaanAdminBundle]: access level for google should add groups #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numkil
reviewed
Mar 19, 2018
| $user->addRole($accessLevel); | ||
| /** @var GroupInterface $group */ | ||
| $group = $this->em->getRepository('KunstmaanAdminBundle:Group')->findOneBy(['name' => $accessLevel]); | ||
| if (null !== $group) { |
There was a problem hiding this comment.
Maybe we need some fallback so the process doesn't create a user without a role or group and effectively makes the username unusable. Some projects might have custom groups, whereas you can always be sure the roles will be the same.
There was a problem hiding this comment.
Hmm, you configure the groups you want to add in the config.yml so it's your own responsibility to check if the group has roles in it IMHO.
Numkil
approved these changes
Apr 4, 2018
Devolicious
added a commit
that referenced
this pull request
Apr 27, 2018
* 5.0: (29 commits) [MediaBundle] Create runtime config hash using the original image path (#1500) [FormBundle] Update regex translation (#1933) Change label required for choice pagepart (#1934) Change required value for new window menu item (#1932) [Documentation] remove addition to upgrade guide that was merged in incorrectly (#1911) Update add new translation (#1914) [Composer][GeneratorBundle] fix testing + limit fos user to 2.0.* (#1922) update changelog added option to fix the automated tests on the standard edition (#1912) recompile assets update changelog [MultiDomainBundle]: host override should be set before getting default locale (#1889) [KunstmaanAdminBundle]: access level for google should add groups (#1868) [AdminListBundle] Start and end form using tab pane, if it exists (#1890) [NodeBundle]: node data collector should go to node id (#1891) [FormBundle]: add batchsize to export list (#1887) [AdminBundle] use bootstrap's default z-index values & remove unnecessary transition and transform props on app__content (#1885) [Docs]: move to readthedocs documentation (#1880) [GeneratorBundle] Change logic of page title (#1874) [LeadGenerationBundle]: times should not be blank (#1865) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When logging in with Google, the user will receive the ROLES given in access_roles in your configuration. This should not add roles, but should add the kuma groups instead.