Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeneratorBundle] Change logic of page title #1874

Merged
merged 1 commit into from Mar 27, 2018
Merged

[GeneratorBundle] Change logic of page title #1874

merged 1 commit into from Mar 27, 2018

Conversation

treeleaf
Copy link
Contributor

@treeleaf treeleaf commented Mar 20, 2018 •
edited by sandergo90

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

@treeleaf treeleaf added this to the 5.0.6 milestone Mar 20, 2018
diskwriter
diskwriter reviewed Mar 20, 2018
View reviewed changes
...ndle/Resources/SensioGeneratorBundle/skeleton/layout/Resources/views/Layout/layout.html.twig
{% if page is defined and nodemenu.getActiveForDepth(2) is not null %}
{{ get_title_for(page) ~ ' - ' ~ websitetitle|trans }}
{% else %}
{{ websitetitle | trans }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be more of an OR situation?
As in: As soon as the SEO title is set it should replace the website title from translations completely. Otherwise the user is limited in their SEO titles because it will always include the site title.

@sandergo90 sandergo90 merged commit f6cb020 into Kunstmaan:5.0 Mar 27, 2018
@treeleaf treeleaf deleted the feature/seo-title branch March 27, 2018 12:01
Devolicious added a commit that referenced this pull request Apr 27, 2018
@Devolicious
Merge branch '5.0'
569cc3f 
* 5.0: (29 commits)
  [MediaBundle] Create runtime config hash using the original image path (#1500)
  [FormBundle] Update regex translation (#1933)
  Change label required for choice pagepart (#1934)
  Change required value for new window menu item (#1932)
  [Documentation] remove addition to upgrade guide that was merged in incorrectly (#1911)
  Update add new translation (#1914)
  [Composer][GeneratorBundle] fix testing + limit fos user to 2.0.* (#1922)
  update changelog
  added option to fix the automated tests on the standard edition (#1912)
  recompile assets
  update changelog
  [MultiDomainBundle]: host override should be set before getting default locale (#1889)
  [KunstmaanAdminBundle]: access level for google should add groups (#1868)
  [AdminListBundle] Start and end form using tab pane, if it exists (#1890)
  [NodeBundle]: node data collector should go to node id (#1891)
  [FormBundle]: add batchsize to export list (#1887)
  [AdminBundle] use bootstrap's default z-index values & remove unnecessary transition and transform props on app__content (#1885)
  [Docs]: move to readthedocs documentation (#1880)
  [GeneratorBundle] Change logic of page title (#1874)
  [LeadGenerationBundle]: times should not be blank (#1865)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diskwriter diskwriter diskwriter left review comments

@sandergo90 sandergo90 sandergo90 approved these changes

Assignees
No one assigned
Labels
Profile: Backend Profile: Frontend Type: Bugfix
Projects
None yet
Milestone
5.0.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@treeleaf @sandergo90 @diskwriter